Support multiple displays for PagePopup

New SELECT Popup: Support multiple displays for PagePopup

The render process only knows the WebScreenInfo for only one screen so we cannot handle adjusting popup position for multiple monitor setups.

This removes the ability to adjust popup position to fit inside the available screen space and show the popup always attached to the anchor element.

Popup size and whether the popup is displayed above or below the anchor element is still determined by screen info so this is not perfect but it is what the PopupContainer implimentation was doing.

BUG=475956
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193744

[keishi, 2015-04-14 11:01:04]

keishi@chromium.org changed reviewers:
+ tkent@chromium.org

[tkent, 2015-04-14 11:09:33]

https://codereview.chromium.org/1087743002/diff/1/Source/core/page/DOMWindowP...
File Source/core/page/DOMWindowPagePopup.h (right):

https://codereview.chromium.org/1087743002/diff/1/Source/core/page/DOMWindowP...
Source/core/page/DOMWindowPagePopup.h:56: explicit
DOMWindowPagePopup(PagePopup*, PagePopupClient*);
|explicit| is unnecessary.

https://codereview.chromium.org/1087743002/diff/1/Source/core/page/PagePopupC...
File Source/core/page/PagePopupController.cpp (right):

https://codereview.chromium.org/1087743002/diff/1/Source/core/page/PagePopupC...
Source/core/page/PagePopupController.cpp:45: ASSERT(popup);
nit: So, the argument and m_popup should be |PagePopup&|

https://codereview.chromium.org/1087743002/diff/1/Source/core/page/PagePopupC...
File Source/core/page/PagePopupController.idl (right):

https://codereview.chromium.org/1087743002/diff/1/Source/core/page/PagePopupC...
Source/core/page/PagePopupController.idl:45: void setWindowRect(long x, long
y,long width, long height);
We should have a comment why window.resizeTo/moveTo are not usable.

https://codereview.chromium.org/1087743002/diff/1/Source/web/resources/picker...
File Source/web/resources/pickerCommon.js (right):

https://codereview.chromium.org/1087743002/diff/1/Source/web/resources/picker...
Source/web/resources/pickerCommon.js:136: } else {console.log("awrv2");
remove this change

[tkent, 2015-04-14 11:10:05]

https://codereview.chromium.org/1087743002/diff/1/Source/core/page/PagePopupC...
File Source/core/page/PagePopupController.h (right):

https://codereview.chromium.org/1087743002/diff/1/Source/core/page/PagePopupC...
Source/core/page/PagePopupController.h:64: explicit
PagePopupController(PagePopup*, PagePopupClient*);
|explicit| is unnecessary.

[keishi, 2015-04-14 11:17:46]

https://codereview.chromium.org/1087743002/diff/1/Source/core/page/DOMWindowP...
File Source/core/page/DOMWindowPagePopup.h (right):

https://codereview.chromium.org/1087743002/diff/1/Source/core/page/DOMWindowP...
Source/core/page/DOMWindowPagePopup.h:56: explicit
DOMWindowPagePopup(PagePopup*, PagePopupClient*);
On 2015/04/14 11:09:32, tkent wrote:
> |explicit| is unnecessary.

Done.

https://codereview.chromium.org/1087743002/diff/1/Source/core/page/PagePopupC...
File Source/core/page/PagePopupController.cpp (right):

https://codereview.chromium.org/1087743002/diff/1/Source/core/page/PagePopupC...
Source/core/page/PagePopupController.cpp:45: ASSERT(popup);
On 2015/04/14 11:09:32, tkent wrote:
> nit: So, the argument and m_popup should be |PagePopup&|

Done.

https://codereview.chromium.org/1087743002/diff/1/Source/core/page/PagePopupC...
File Source/core/page/PagePopupController.h (right):

https://codereview.chromium.org/1087743002/diff/1/Source/core/page/PagePopupC...
Source/core/page/PagePopupController.h:64: explicit
PagePopupController(PagePopup*, PagePopupClient*);
On 2015/04/14 11:10:05, tkent wrote:
> |explicit| is unnecessary.

Done.

https://codereview.chromium.org/1087743002/diff/1/Source/core/page/PagePopupC...
File Source/core/page/PagePopupController.idl (right):

https://codereview.chromium.org/1087743002/diff/1/Source/core/page/PagePopupC...
Source/core/page/PagePopupController.idl:45: void setWindowRect(long x, long
y,long width, long height);
On 2015/04/14 11:09:33, tkent wrote:
> We should have a comment why window.resizeTo/moveTo are not usable.
> 

Done.

https://codereview.chromium.org/1087743002/diff/1/Source/web/resources/picker...
File Source/web/resources/pickerCommon.js (right):

https://codereview.chromium.org/1087743002/diff/1/Source/web/resources/picker...
Source/web/resources/pickerCommon.js:136: } else {console.log("awrv2");
On 2015/04/14 11:09:33, tkent wrote:
> remove this change

Done.

[tkent, 2015-04-14 11:21:38]

https://codereview.chromium.org/1087743002/diff/20001/Source/core/page/DOMWin...
File Source/core/page/DOMWindowPagePopup.cpp (right):

https://codereview.chromium.org/1087743002/diff/20001/Source/core/page/DOMWin...
Source/core/page/DOMWindowPagePopup.cpp:39:
DOMWindowPagePopup::DOMWindowPagePopup(PagePopup* popup, PagePopupClient*
popupClient)
Ditto.

https://codereview.chromium.org/1087743002/diff/20001/Source/core/page/DOMWin...
Source/core/page/DOMWindowPagePopup.cpp:59: void
DOMWindowPagePopup::install(LocalDOMWindow& window, PagePopup* popup,
PagePopupClient* popupClient)
Ditto.

https://codereview.chromium.org/1087743002/diff/20001/Source/core/page/DOMWin...
File Source/core/page/DOMWindowPagePopup.h (right):

https://codereview.chromium.org/1087743002/diff/20001/Source/core/page/DOMWin...
Source/core/page/DOMWindowPagePopup.h:49: static void install(LocalDOMWindow&,
PagePopup*, PagePopupClient*);
PagePopup* -> PagePopup&

https://codereview.chromium.org/1087743002/diff/20001/Source/core/page/DOMWin...
Source/core/page/DOMWindowPagePopup.h:56: DOMWindowPagePopup(PagePopup*,
PagePopupClient*);
Ditto.

https://codereview.chromium.org/1087743002/diff/20001/Source/core/page/PagePo...
File Source/core/page/PagePopupController.h (right):

https://codereview.chromium.org/1087743002/diff/20001/Source/core/page/PagePo...
Source/core/page/PagePopupController.h:64: PagePopupController(PagePopup*,
PagePopupClient*);
Ditto.

[keishi, 2015-04-14 11:34:56]

https://codereview.chromium.org/1087743002/diff/20001/Source/core/page/DOMWin...
File Source/core/page/DOMWindowPagePopup.cpp (right):

https://codereview.chromium.org/1087743002/diff/20001/Source/core/page/DOMWin...
Source/core/page/DOMWindowPagePopup.cpp:39:
DOMWindowPagePopup::DOMWindowPagePopup(PagePopup* popup, PagePopupClient*
popupClient)
On 2015/04/14 11:21:38, tkent wrote:
> Ditto.

Sorry. Done.

https://codereview.chromium.org/1087743002/diff/20001/Source/core/page/DOMWin...
Source/core/page/DOMWindowPagePopup.cpp:59: void
DOMWindowPagePopup::install(LocalDOMWindow& window, PagePopup* popup,
PagePopupClient* popupClient)
On 2015/04/14 11:21:38, tkent wrote:
> Ditto.

Done.

https://codereview.chromium.org/1087743002/diff/20001/Source/core/page/DOMWin...
File Source/core/page/DOMWindowPagePopup.h (right):

https://codereview.chromium.org/1087743002/diff/20001/Source/core/page/DOMWin...
Source/core/page/DOMWindowPagePopup.h:49: static void install(LocalDOMWindow&,
PagePopup*, PagePopupClient*);
On 2015/04/14 11:21:38, tkent wrote:
> PagePopup* -> PagePopup&

Done.

https://codereview.chromium.org/1087743002/diff/20001/Source/core/page/DOMWin...
Source/core/page/DOMWindowPagePopup.h:56: DOMWindowPagePopup(PagePopup*,
PagePopupClient*);
On 2015/04/14 11:21:38, tkent wrote:
> Ditto.

Done.

https://codereview.chromium.org/1087743002/diff/20001/Source/core/page/PagePo...
File Source/core/page/PagePopupController.h (right):

https://codereview.chromium.org/1087743002/diff/20001/Source/core/page/PagePo...
Source/core/page/PagePopupController.h:64: PagePopupController(PagePopup*,
PagePopupClient*);
On 2015/04/14 11:21:38, tkent wrote:
> Ditto.

Done.

[tkent, 2015-04-14 11:36:53]

lgtm

https://codereview.chromium.org/1087743002/diff/40001/Source/core/page/PagePo...
File Source/core/page/PagePopup.h (right):

https://codereview.chromium.org/1087743002/diff/40001/Source/core/page/PagePo...
Source/core/page/PagePopup.h:34: #include "platform/geometry/IntRect.h"
|class IntRect;| is enough.

[keishi, 2015-04-15 02:26:10]

https://codereview.chromium.org/1087743002/diff/40001/Source/core/page/PagePo...
File Source/core/page/PagePopup.h (right):

https://codereview.chromium.org/1087743002/diff/40001/Source/core/page/PagePo...
Source/core/page/PagePopup.h:34: #include "platform/geometry/IntRect.h"
On 2015/04/14 11:36:53, tkent wrote:
> |class IntRect;| is enough.

Done.

[keishi, 2015-04-15 02:26:13]

The CQ bit was checked by keishi@chromium.org

[keishi, 2015-04-15 02:26:14]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/1087743002/#ps60001
(title: "fixed IntRect inclusion")

[commit-bot: I haz the power, 2015-04-15 02:26:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1087743002/60001

[commit-bot: I haz the power, 2015-04-15 04:05:48]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193744