Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1643)

Unified Diff: Source/web/WebPagePopupImpl.cpp

Issue 1087743002: Support multiple displays for PagePopup (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: fixed IntRect inclusion Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/WebPagePopupImpl.h ('k') | Source/web/resources/pickerCommon.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebPagePopupImpl.cpp
diff --git a/Source/web/WebPagePopupImpl.cpp b/Source/web/WebPagePopupImpl.cpp
index 8f2c7086ab9d7cab1f2fd6f9c7531f66d12fd074..3968caddc4948ed3768fb4c03d5baa1aaa5c35c3 100644
--- a/Source/web/WebPagePopupImpl.cpp
+++ b/Source/web/WebPagePopupImpl.cpp
@@ -77,6 +77,12 @@ public:
ASSERT(m_popup->widgetClient());
}
+ virtual void setWindowRect(const IntRect& rect) override
+ {
+ m_popup->m_windowRectInScreen = rect;
+ m_popup->widgetClient()->setWindowRect(m_popup->m_windowRectInScreen);
+ }
+
private:
virtual void closeWindowSoon() override
{
@@ -88,12 +94,6 @@ private:
return IntRect(m_popup->m_windowRectInScreen.x, m_popup->m_windowRectInScreen.y, m_popup->m_windowRectInScreen.width, m_popup->m_windowRectInScreen.height);
}
- virtual void setWindowRect(const IntRect& rect) override
- {
- m_popup->m_windowRectInScreen = rect;
- m_popup->widgetClient()->setWindowRect(m_popup->m_windowRectInScreen);
- }
-
virtual IntRect viewportToScreen(const IntRect& rect) const override
{
IntRect rectInScreen(rect);
@@ -259,7 +259,7 @@ bool WebPagePopupImpl::initializePage()
cache->childrenChanged(&m_popupClient->ownerElement());
ASSERT(frame->localDOMWindow());
- DOMWindowPagePopup::install(*frame->localDOMWindow(), m_popupClient);
+ DOMWindowPagePopup::install(*frame->localDOMWindow(), *this, m_popupClient);
ASSERT(m_popupClient->ownerElement().document().existingAXObjectCache() == frame->document()->existingAXObjectCache());
RefPtr<SharedBuffer> data = SharedBuffer::create();
@@ -299,6 +299,11 @@ AXObject* WebPagePopupImpl::rootAXObject()
return toAXObjectCacheImpl(cache)->getOrCreate(document->layoutView());
}
+void WebPagePopupImpl::setWindowRect(const IntRect& rect)
+{
+ m_chromeClient->setWindowRect(rect);
+}
+
void WebPagePopupImpl::setRootGraphicsLayer(GraphicsLayer* layer)
{
m_rootGraphicsLayer = layer;
« no previous file with comments | « Source/web/WebPagePopupImpl.h ('k') | Source/web/resources/pickerCommon.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698