Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 1087493002: Support [Replaceable] for screen, pageXOffset, pageYOffset (Closed)

Created:
5 years, 8 months ago by Abhijeet Kandalkar Slow
Modified:
5 years, 8 months ago
Reviewers:
vivekg, philipj_slow
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Support [Replaceable] for screen, pageXOffset, pageYOffset This updates screen, pageXOffset, pageYOffset to match changes to the CSSOM View spec[1]. [1] http://dev.w3.org/csswg/cssom-view/#extensions-to-the-window-interface BUG=474472 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193798

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -25 lines) Patch
M LayoutTests/fast/dom/Window/get-set-properties.html View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/dom/Window/get-set-properties-expected.txt View 2 chunks +6 lines, -6 lines 0 comments Download
M LayoutTests/fast/js/var-declarations-shadowing.html View 2 chunks +6 lines, -6 lines 0 comments Download
M LayoutTests/fast/js/var-declarations-shadowing-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/frame/Window.idl View 1 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Abhijeet Kandalkar Slow
Please review patch.
5 years, 8 months ago (2015-04-13 11:41:56 UTC) #2
zcorpan
Can remove this: // FIXME: None of the CCSOM View Module attributes should be [Replaceable].
5 years, 8 months ago (2015-04-13 13:46:28 UTC) #3
philipj_slow
LGTM if the FIXME is removed. I can't find a reason to suspect that this ...
5 years, 8 months ago (2015-04-15 11:28:09 UTC) #4
Abhijeet Kandalkar Slow
Review comments are incorporated.
5 years, 8 months ago (2015-04-15 13:11:45 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1087493002/20001
5 years, 8 months ago (2015-04-15 13:12:50 UTC) #8
commit-bot: I haz the power
This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-15 15:45:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1087493002/20001
5 years, 8 months ago (2015-04-15 16:06:19 UTC) #12
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 16:07:29 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193798

Powered by Google App Engine
This is Rietveld 408576698