Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1021)

Unified Diff: Source/core/frame/Window.idl

Issue 1087493002: Support [Replaceable] for screen, pageXOffset, pageYOffset (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/js/var-declarations-shadowing-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/frame/Window.idl
diff --git a/Source/core/frame/Window.idl b/Source/core/frame/Window.idl
index a77a67947ffeafcf391ccb3340748a1d5326ed79..896a44fac70d5edf0d04b37addaec1a5ad30e4f3 100644
--- a/Source/core/frame/Window.idl
+++ b/Source/core/frame/Window.idl
@@ -105,7 +105,7 @@
// CSSOM View Module
// http://dev.w3.org/csswg/cssom-view/#extensions-to-the-window-interface
[NewObject] MediaQueryList matchMedia(DOMString query);
- [SameObject] readonly attribute Screen screen;
+ [SameObject, Replaceable] readonly attribute Screen screen;
// browsing context
// FIXME: The x and y arguments should not be optional. crbug.com/453421
@@ -115,15 +115,14 @@
void resizeBy(optional long x, optional long y);
// viewport
- // FIXME: None of the CCSOM View Module attributes should be [Replaceable].
[Replaceable] readonly attribute long innerWidth;
[Replaceable] readonly attribute long innerHeight;
// viewport scrolling
[Replaceable] readonly attribute double scrollX;
- readonly attribute double pageXOffset;
+ [Replaceable] readonly attribute double pageXOffset;
[Replaceable] readonly attribute double scrollY;
- readonly attribute double pageYOffset;
+ [Replaceable] readonly attribute double pageYOffset;
[RuntimeEnabled=CSSOMSmoothScroll] void scroll(optional ScrollToOptions options);
void scroll(unrestricted double x, unrestricted double y);
[RuntimeEnabled=CSSOMSmoothScroll] void scrollTo(optional ScrollToOptions options);
« no previous file with comments | « LayoutTests/fast/js/var-declarations-shadowing-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698