LayoutTests/fast/js/var-declarations-shadowing.html - Issue 1087493002: Support [Replaceable] for screen, pageXOffset, pageYOffset

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/js/var-declarations-shadowing.html

Issue 1087493002: Support [Replaceable] for screen, pageXOffset, pageYOffset (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/Window/get-set-properties-expected.txt ('k') | LayoutTests/fast/js/var-declarations-shadowing-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/js/var-declarations-shadowing.html

diff --git a/LayoutTests/fast/js/var-declarations-shadowing.html b/LayoutTests/fast/js/var-declarations-shadowing.html

index b213525d3e3dd069351850f0ce8491958a601990..81e133bbfb116b34c6118ac5b260c5d606101dc7 100644

--- a/LayoutTests/fast/js/var-declarations-shadowing.html

+++ b/LayoutTests/fast/js/var-declarations-shadowing.html

@@ -250,8 +250,8 @@ shouldBe(eval('defaultstatus == marker'), "eval('defaultstatus == marker')", tru

try {

eval("var screen = marker");

} catch(e) { }

-shouldBe(screen == marker, "screen == marker", false);

-shouldBe(eval('screen == marker'), "eval('screen == marker')", false);

+shouldBe(screen == marker, "screen == marker", true);

+shouldBe(eval('screen == marker'), "eval('screen == marker')", true);

try {

eval("var history = marker");

@@ -270,14 +270,14 @@ shouldBe(eval('frameElement == marker'), "eval('frameElement == marker')", false

try {

eval("var pageXOffset = marker");

} catch(e) { }

-shouldBe(pageXOffset == marker, "pageXOffset == marker", false);

-shouldBe(eval('pageXOffset == marker'), "eval('pageXOffset == marker')", false);

+shouldBe(pageXOffset == marker, "pageXOffset == marker", true);

+shouldBe(eval('pageXOffset == marker'), "eval('pageXOffset == marker')", true);

try {

eval("var pageYOffset = marker");

} catch(e) { }

-shouldBe(pageYOffset == marker, "pageYOffset == marker", false);

-shouldBe(eval('pageYOffset == marker'), "eval('pageYOffset == marker')", false);

+shouldBe(pageYOffset == marker, "pageYOffset == marker", true);

+shouldBe(eval('pageYOffset == marker'), "eval('pageYOffset == marker')", true);

try {

eval("var closed = marker");