Issue 108723006: Gin: Fix console module to be varargs again.

Issue 108723006: Gin: Fix console module to be varargs again. (Closed)

Created:
7 years ago by Aaron Boodman

Modified:
6 years, 11 months ago

Reviewers:
abarth-chromium

CC:
chromium-reviews, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -8 lines)			Patch
M	gin/function_template.h	View	1	2 chunks	+5 lines, -1 line	0 comments	Download
M	gin/function_template.h.pump	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download
M	gin/modules/console.cc	View		1 chunk	+6 lines, -1 line	0 comments	Download
M	gin/test/expect.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/apps/js/bindings/connector.js	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	mojo/apps/js/main.js	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 7 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aa@chromium.org/108723006/40001

7 years ago (2013-12-22 08:01:54 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=239621

7 years ago (2013-12-22 10:20:12 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aa@chromium.org/108723006/40001

7 years ago (2013-12-23 01:26:09 UTC) #5

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=239688

7 years ago (2013-12-23 04:05:09 UTC) #6

Aaron Boodman

6 years, 11 months ago (2014-01-06 22:21:10 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 manually as r243183 (presubmit successful).