Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: gin/function_template.h.pump

Issue 108723006: Gin: Fix console module to be varargs again. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ad Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gin/function_template.h ('k') | gin/modules/console.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/function_template.h.pump
diff --git a/gin/function_template.h.pump b/gin/function_template.h.pump
index 4870faaccf72731e07b81df2a36e934cd20e6dec..b074bdefd5df05c4598a38c5f360ddccdc88e691 100644
--- a/gin/function_template.h.pump
+++ b/gin/function_template.h.pump
@@ -140,6 +140,11 @@ inline bool GetNextArgument(Arguments* args, int create_flags, bool is_first,
*result = *args;
return true;
}
+inline bool GetNextArgument(Arguments* args, int create_flags, bool is_first,
+ Arguments** result) {
+ *result = args;
+ return true;
+}
// It's common for clients to just need the isolate, so we make that easy.
inline bool GetNextArgument(Arguments* args, int create_flags,
@@ -205,6 +210,7 @@ v8::Local<v8::FunctionTemplate> CreateFunctionTemplate(
gin::Handle<HolderT> holder = CreateHandle(
isolate, new HolderT(callback, callback_flags));
return v8::FunctionTemplate::New(
+ isolate,
&internal::Dispatcher<Sig>::DispatchToCallback,
ConvertToV8<internal::CallbackHolderBase*>(isolate, holder.get()));
}
« no previous file with comments | « gin/function_template.h ('k') | gin/modules/console.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698