Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Unified Diff: gin/function_template.h

Issue 108723006: Gin: Fix console module to be varargs again. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ad Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gin/function_template.h.pump » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/function_template.h
diff --git a/gin/function_template.h b/gin/function_template.h
index 31f67fa3b3d97bff6b147b2002e761956e429b4b..29cb336391ca50fdfbbb05ae2ef351a1c04ac6c3 100644
--- a/gin/function_template.h
+++ b/gin/function_template.h
@@ -62,7 +62,6 @@ struct CallbackParamTraits<const T*> {
class GIN_EXPORT CallbackHolderBase : public Wrappable<CallbackHolderBase> {
public:
static WrapperInfo kWrapperInfo;
-
protected:
virtual ~CallbackHolderBase() {}
};
@@ -269,6 +268,11 @@ inline bool GetNextArgument(Arguments* args, int create_flags, bool is_first,
*result = *args;
return true;
}
+inline bool GetNextArgument(Arguments* args, int create_flags, bool is_first,
+ Arguments** result) {
+ *result = args;
+ return true;
+}
// It's common for clients to just need the isolate, so we make that easy.
inline bool GetNextArgument(Arguments* args, int create_flags,
« no previous file with comments | « no previous file | gin/function_template.h.pump » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698