chrome/browser/process_singleton_win_unittest.cc - Issue 1086363003: Handled nullptr argument in WaitForExit() and WaitForExitWithTimeout() methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/process_singleton_win_unittest.cc

Issue 1086363003: Handled nullptr argument in WaitForExit() and WaitForExitWithTimeout() methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comments incorporated. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/app/chrome_watcher_client_unittest_win.cc ('k') | components/browser_watcher/exit_code_watcher_win_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/process_singleton_win_unittest.cc

diff --git a/chrome/browser/process_singleton_win_unittest.cc b/chrome/browser/process_singleton_win_unittest.cc

index c19e100f0dad8e038dd06165ec8303bc30cdefb7..332c5a2881a7aca8c572dbb2a907e4452747c637 100644

--- a/chrome/browser/process_singleton_win_unittest.cc

+++ b/chrome/browser/process_singleton_win_unittest.cc

@@ -161,8 +161,7 @@ class ProcessSingletonTest : public base::MultiProcessTest {

if (browser_victim_.IsValid()) {

EXPECT_TRUE(::SetEvent(continue_event_.Get()));

- int exit_code = 0;

- EXPECT_TRUE(browser_victim_.WaitForExit(&exit_code));

+ EXPECT_TRUE(browser_victim_.WaitForExit(nullptr));

}

base::MultiProcessTest::TearDown();

« no previous file with comments | « chrome/app/chrome_watcher_client_unittest_win.cc ('k') | components/browser_watcher/exit_code_watcher_win_unittest.cc » ('j') | no next file with comments »