chrome/app/chrome_watcher_client_unittest_win.cc - Issue 1086363003: Handled nullptr argument in WaitForExit() and WaitForExitWithTimeout() methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/chrome_watcher_client_unittest_win.cc

Issue 1086363003: Handled nullptr argument in WaitForExit() and WaitForExitWithTimeout() methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comments incorporated. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/app/chrome_watcher_client_unittest_win.cc

diff --git a/chrome/app/chrome_watcher_client_unittest_win.cc b/chrome/app/chrome_watcher_client_unittest_win.cc

index 5b916138d14ea2f46a2cdc12a968c138f0005cd3..9f371235c96b08331ff1062f84eb74d760b87c14 100644

--- a/chrome/app/chrome_watcher_client_unittest_win.cc

+++ b/chrome/app/chrome_watcher_client_unittest_win.cc

@@ -221,8 +221,7 @@ class ChromeWatcherClientTest : public testing::Test {

void TearDown() override {

// Even if we never launched, the following is harmless.

SignalExit();

- int exit_code = 0;

- thread_.client().WaitForExit(&exit_code);

+ thread_.client().WaitForExit(nullptr);

thread_.Join();

}

« no previous file with comments | « base/process/process_win.cc ('k') | chrome/browser/process_singleton_win_unittest.cc » ('j') | no next file with comments »