Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: components/browser_watcher/exit_code_watcher_win_unittest.cc

Issue 1086363003: Handled nullptr argument in WaitForExit() and WaitForExitWithTimeout() methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comments incorporated. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/process_singleton_win_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/browser_watcher/exit_code_watcher_win_unittest.cc
diff --git a/components/browser_watcher/exit_code_watcher_win_unittest.cc b/components/browser_watcher/exit_code_watcher_win_unittest.cc
index e89301bfe8f26098915b7adf4923b5132ab9a50b..f9d495a324b8c0db11cc3624fe1ba57aba26d4e7 100644
--- a/components/browser_watcher/exit_code_watcher_win_unittest.cc
+++ b/components/browser_watcher/exit_code_watcher_win_unittest.cc
@@ -39,8 +39,7 @@ class ScopedSleeperProcess {
~ScopedSleeperProcess() {
if (process_.IsValid()) {
process_.Terminate(-1, false);
- int exit_code = 0;
- EXPECT_TRUE(process_.WaitForExit(&exit_code));
+ EXPECT_TRUE(process_.WaitForExit(nullptr));
}
}
« no previous file with comments | « chrome/browser/process_singleton_win_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698