Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Unified Diff: base/process/process_win.cc

Issue 1086363003: Handled nullptr argument in WaitForExit() and WaitForExitWithTimeout() methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comments incorporated. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/process/process_posix.cc ('k') | chrome/app/chrome_watcher_client_unittest_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/process/process_win.cc
diff --git a/base/process/process_win.cc b/base/process/process_win.cc
index 0d312a3599088eabf4bc2043a5f875b6d1f9d019..2ad72c706b0549b9dbc544b686eac2658f0ab571 100644
--- a/base/process/process_win.cc
+++ b/base/process/process_win.cc
@@ -154,7 +154,8 @@ bool Process::WaitForExitWithTimeout(TimeDelta timeout, int* exit_code) {
if (!::GetExitCodeProcess(Handle(), &temp_code))
return false;
- *exit_code = temp_code;
+ if (exit_code)
+ *exit_code = temp_code;
return true;
}
« no previous file with comments | « base/process/process_posix.cc ('k') | chrome/app/chrome_watcher_client_unittest_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698