Upgrade 3rd packages

Upgrade 3rd packages

BUG=461614
R=nodir@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=294835

[sheyang, 2015-04-14 17:43:49]

sheyang@chromium.org changed reviewers:
+ nodir@chromium.org

[nodir, 2015-04-14 17:52:23]

README.chromium files were not updated. Please update them

[sheyang, 2015-04-14 18:50:55]

Updated.

[nodir, 2015-04-15 05:23:31]

https://codereview.chromium.org/1085893002/diff/20001/third_party/google_api_...
File third_party/google_api_python_client/README.chromium (right):

https://codereview.chromium.org/1085893002/diff/20001/third_party/google_api_...
third_party/google_api_python_client/README.chromium:2: Version: v1.3.1
Isn't the version you have uploaded newer?

https://codereview.chromium.org/1085893002/diff/20001/third_party/google_api_...
third_party/google_api_python_client/README.chromium:7: See also
MODIFICATIONS.diff
Local modifications are modifications that we made. Did we make all changes in
MODIFICATIONS.diff?

[sheyang, 2015-04-15 16:41:43]

https://codereview.chromium.org/1085893002/diff/20001/third_party/google_api_...
File third_party/google_api_python_client/README.chromium (right):

https://codereview.chromium.org/1085893002/diff/20001/third_party/google_api_...
third_party/google_api_python_client/README.chromium:2: Version: v1.3.1
On 2015/04/15 05:23:31, nodir wrote:
> Isn't the version you have uploaded newer?

I didn't upgrade this package. Just fixed the imports.

https://codereview.chromium.org/1085893002/diff/20001/third_party/google_api_...
third_party/google_api_python_client/README.chromium:7: See also
MODIFICATIONS.diff
On 2015/04/15 05:23:31, nodir wrote:
> Local modifications are modifications that we made. Did we make all changes in
> MODIFICATIONS.diff?

Updated by removing the diffs from oauth2client for the upgrade.

[nodir, 2015-04-16 00:41:28]

https://codereview.chromium.org/1085893002/diff/20001/third_party/google_api_...
File third_party/google_api_python_client/README.chromium (right):

https://codereview.chromium.org/1085893002/diff/20001/third_party/google_api_...
third_party/google_api_python_client/README.chromium:2: Version: v1.3.1
On 2015/04/15 16:41:43, sheyang wrote:
> On 2015/04/15 05:23:31, nodir wrote:
> > Isn't the version you have uploaded newer?
> 
> I didn't upgrade this package. Just fixed the imports.

Oh, I don't think this is the right approach. This is fixable on the side that
uses apiclient, so we should not modify third_party code for this reason.

[nodir, 2015-04-16 00:49:40]

in IM, sheyang@ said it is not the first time we change 3rd party tools to make
imports work. Thus, lgtm

[sheyang, 2015-04-16 00:56:25]

The CQ bit was checked by sheyang@chromium.org

[commit-bot: I haz the power, 2015-04-16 00:56:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1085893002/40001

[commit-bot: I haz the power, 2015-04-16 00:59:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-16 00:59:06]

Presubmit check for 1085893002-40001 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
tests/gclient_smoketest.py (54.54s) failed
Ffatal: reference is not a tree: 574074e02d99ab21571364286086ea5cbcfa17f1
EE..............................................
======================================================================
ERROR: testBlinkDEPSChangeUsingGit (__main__.BlinkDEPSTransitionSmokeTest)
Like testBlinkDEPSChangeUsingGclient, but move the main project using
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 1630, in testBlinkDEPSChangeUsingGit
    cwd=self.checkout_path)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
484, in check_call
    check_call_out(args, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
478, in check_call_out
    returncode, args, kwargs.get('cwd'), out[0], out[1])
CalledProcessError: Command git checkout -q
574074e02d99ab21571364286086ea5cbcfa17f1 returned non-zero exit status 128 in
/tmp/trialFsTriE/__main__.BlinkDEPSTransitionSmokeTest.testBlinkDEPSChangeUsingGit/src

======================================================================
ERROR: testBlinkLocalBranchesArePreserved
(__main__.BlinkDEPSTransitionSmokeTest)
Checks that the state of local git branches are effectively preserved
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 1656, in
testBlinkLocalBranchesArePreserved
    self.CheckStatusPreMergePoint()
  File "tests/gclient_smoketest.py", line 1558, in CheckStatusPreMergePoint
    self.blink), self.blink_git_url)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/scm.py", line
121, in Capture
    cwd=cwd, stderr=subprocess2.PIPE, env=env, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
515, in check_output
    return check_call_out(args, stdout=PIPE, **kwargs)[0]
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
475, in check_call_out
    out, returncode = communicate(args, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
449, in communicate
    proc = Popen(args, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
253, in __init__
    % (str(e), kwargs.get('cwd'), args[0]))
OSError: Execution failed with error: [Errno 2] No such file or directory:
'/tmp/trialFsTriE/__main__.BlinkDEPSTransitionSmokeTest.testBlinkLocalBranchesArePreserved/src/third_party/WebKit'.
Check that
/tmp/trialFsTriE/__main__.BlinkDEPSTransitionSmokeTest.testBlinkLocalBranchesArePreserved/src/third_party/WebKit
or git exist and have execution permission.

======================================================================
FAIL: testBlinkDEPSChangeUsingGclient (__main__.BlinkDEPSTransitionSmokeTest)
Checks that {src,blink} repos are consistent when syncing going back and
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 1601, in
testBlinkDEPSChangeUsingGclient
    self.assertEqual(res[2], 0, 'DEPS change sync failed.')
AssertionError: DEPS change sync failed.

----------------------------------------------------------------------
Ran 49 tests in 54.323s

FAILED (failures=1, errors=2)


Presubmit checks took 133.3s to calculate.

[sheyang, 2015-04-16 01:06:33]

The CQ bit was checked by sheyang@chromium.org

[sheyang, 2015-04-16 01:06:33]

The patchset sent to the CQ was uploaded after l-g-t-m from nodir@chromium.org
Link to the patchset: https://codereview.chromium.org/1085893002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2015-04-16 01:06:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1085893002/60001

[commit-bot: I haz the power, 2015-04-16 01:08:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-16 01:08:59]

Presubmit check for 1085893002-60001 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
tests/checkout_test.py (37.78s) failed
Cloning into '/tmp/trialtxGAl9/__main__.GitCheckout.testAll/foo'...
done.
Switched to branch 'master'
Already on 'master'
.ECloning into '/tmp/trialtxGAl9/__main__.GitCheckout.testMove/foo'...
done.
.Cloning into '/tmp/trialtxGAl9/__main__.GitCheckout.testProcess/foo'...
done.
....................
======================================================================
ERROR: testException (__main__.GitCheckout)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/checkout_test.py", line 347, in setUp
    self.enabled = self.FAKE_REPOS.set_up_git()
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line 359, in set_up_git
    self.set_up()
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line 211, in set_up
    self.cleanup_dirt()
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line 229, in cleanup_dirt
    if not self.tear_down_git():
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line 276, in tear_down_git
    wait_for_port_to_free(self.host, self.git_port)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line 161, in wait_for_port_to_free
    assert False, '%d is still bound' % port
AssertionError: 20000 is still bound

----------------------------------------------------------------------
Ran 23 tests in 37.584s

FAILED (errors=1)


Presubmit checks took 124.3s to calculate.

Was the presubmit check useful? If not, run "git cl presubmit -v"
to figure out which PRESUBMIT.py was run, then run git blame
on the file to figure out who to ask for help.

[sheyang, 2015-04-16 01:12:43]

Committed patchset #4 (id:60001) manually as 294835 (presubmit successful).

[Adrian Kuegel, 2015-04-16 11:05:48]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1094533003/ by akuegel@chromium.org.

The reason for reverting is: This might have broken some internal tryserver
bots..

[Adrian Kuegel, 2015-04-16 11:36:27]

akuegel@chromium.org changed reviewers:
+ akuegel@chromium.org

[Adrian Kuegel, 2015-04-16 11:36:28]

I can confirm that this CL caused the breakage, and I have a suspicion what
exactly caused it (see my comment).

https://codereview.chromium.org/1085893002/diff/60001/third_party/oauth2clien...
File third_party/oauth2client/client.py (right):

https://codereview.chromium.org/1085893002/diff/60001/third_party/oauth2clien...
third_party/oauth2client/client.py:48: from oauth2client import crypt
From the error message I gather that this was the reason for the breakage.

[nodir, 2015-04-16 15:31:58]

This CL is dangerous indeed.

Sheng, I assume you update oauth2client because v1.3.1 requires it. Can we use
an older version of apiclient that is compatible with oauth2client v1.2?

FTR: breakage:
https://groups.google.com/a/google.com/d/msg/chrome-troopers/dTnT1a9HMRg/iHj1...

[sheyang, 2015-04-16 16:20:48]

Yes this is a quite risky CL.

I'll try to use googleapiclient v 1.2 then without touch existing packages..

Best regards,

Sheng

On Thu, Apr 16, 2015 at 8:31 AM, <nodir@chromium.org> wrote:

> This CL is dangerous indeed.
>
> Sheng, I assume you update oauth2client because v1.3.1 requires it. Can we
> use
> an older version of apiclient that is compatible with oauth2client v1.2?
>
> FTR: breakage:
> https://groups.google.com/a/google.com/d/msg/chrome-troopers/dTnT1a9HMRg/
> iHj1uOCbKZMJ
>
> https://codereview.chromium.org/1085893002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.