third_party/google_api_python_client/README.chromium - Issue 1085893002: Upgrade 3rd packages

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/google_api_python_client/README.chromium

Issue 1085893002: Upgrade 3rd packages (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: update readme Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 URL: https://github.com/google/google-api-python-client	1 URL: https://github.com/google/google-api-python-client

2 Version: v1.3.1	2 Version: v1.3.1
	nodir 2015/04/15 05:23:31 Isn't the version you have uploaded newer? Isn't the version you have uploaded newer? sheyang 2015/04/15 16:41:43 I didn't upgrade this package. Just fixed the impo Show quoted text On 2015/04/15 05:23:31, nodir wrote: > Isn't the version you have uploaded newer? I didn't upgrade this package. Just fixed the imports. nodir 2015/04/16 00:41:28 Oh, I don't think this is the right approach. This Show quoted text On 2015/04/15 16:41:43, sheyang wrote: > On 2015/04/15 05:23:31, nodir wrote: > > Isn't the version you have uploaded newer? > > I didn't upgrade this package. Just fixed the imports. Oh, I don't think this is the right approach. This is fixable on the side that uses apiclient, so we should not modify third_party code for this reason.
3 Revision: 49d45a6c3318b75e551c3022020f46c78655f365	3 Revision: 49d45a6c3318b75e551c3022020f46c78655f365

4 License: Apache License, Version 2.0 (the "License")	4 License: Apache License, Version 2.0 (the "License")

5	5

6 No local changes	6 Local modifications:

	7 See also MODIFICATIONS.diff
	nodir 2015/04/15 05:23:31 Local modifications are modifications that we made Local modifications are modifications that we made. Did we make all changes in MODIFICATIONS.diff? sheyang 2015/04/15 16:41:43 Updated by removing the diffs from oauth2client fo Show quoted text On 2015/04/15 05:23:31, nodir wrote: > Local modifications are modifications that we made. Did we make all changes in > MODIFICATIONS.diff? Updated by removing the diffs from oauth2client for the upgrade.
	8

	9 Notes:

	10 Requires the httplib2 and oauth2client library.

OLD	NEW