Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1408)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1085733006: replace to be deprecated v8::PersistentValueMap with v8::GlobalValueMap (Closed)

Created:
5 years, 8 months ago by dcarney
Modified:
5 years, 8 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, extensions-reviews_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

replace to be deprecated v8::PersistentValueMap with v8::GlobalValueMap R=jochen@chromium.org TBR=kalman@chromium.org BUG= Committed: https://crrev.com/36f78b64fc71326e96211036d680ac5f470b5387 Cr-Commit-Position: refs/heads/master@{#326766}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M content/renderer/pepper/message_channel.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/plugin_object.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/v8_schema_registry.h View 1 chunk +1 line, -1 line 0 comments Download
M gin/interceptor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
jochen (gone - plz use gerrit)
lgtm
5 years, 8 months ago (2015-04-24 09:31:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1085733006/1
5 years, 8 months ago (2015-04-24 09:34:43 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-24 10:22:59 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 10:23:56 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/36f78b64fc71326e96211036d680ac5f470b5387
Cr-Commit-Position: refs/heads/master@{#326766}

Powered by Google App Engine
This is Rietveld 408576698