content/renderer/pepper/plugin_object.h - Issue 1085733006: replace to be deprecated v8::PersistentValueMap with v8::GlobalValueMap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/plugin_object.h

Issue 1085733006: replace to be deprecated v8::PersistentValueMap with v8::GlobalValueMap (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/pepper/plugin_object.h

diff --git a/content/renderer/pepper/plugin_object.h b/content/renderer/pepper/plugin_object.h

index 88b608e642a87b96ea55ec1d1856e98d70a00875..85c86aaf39812b82344472aab30c1a3d05b97c82 100644

--- a/content/renderer/pepper/plugin_object.h

+++ b/content/renderer/pepper/plugin_object.h

@@ -84,7 +84,7 @@ class PluginObject : public gin::Wrappable<PluginObject>,

const PPP_Class_Deprecated* ppp_class_;

void* ppp_class_data_;

- v8::StdPersistentValueMap<std::string, v8::FunctionTemplate> template_cache_;

+ v8::StdGlobalValueMap<std::string, v8::FunctionTemplate> template_cache_;

base::WeakPtrFactory<PluginObject> weak_factory_;

« no previous file with comments | « content/renderer/pepper/message_channel.h ('k') | extensions/renderer/v8_schema_registry.h » ('j') | no next file with comments »