extensions/renderer/v8_schema_registry.h - Issue 1085733006: replace to be deprecated v8::PersistentValueMap with v8::GlobalValueMap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/v8_schema_registry.h

Issue 1085733006: replace to be deprecated v8::PersistentValueMap with v8::GlobalValueMap (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/renderer/v8_schema_registry.h

diff --git a/extensions/renderer/v8_schema_registry.h b/extensions/renderer/v8_schema_registry.h

index 5a3b20c31af544835c3230811f243ca5cb93327f..b8c50ead2763065ed7139adfffef3c2803159931 100644

--- a/extensions/renderer/v8_schema_registry.h

+++ b/extensions/renderer/v8_schema_registry.h

@@ -40,7 +40,7 @@ class V8SchemaRegistry {

v8::Handle<v8::Context> GetOrCreateContext(v8::Isolate* isolate);

// Cache of schemas. Created lazily by GetOrCreateContext.

- typedef v8::StdPersistentValueMap<std::string, v8::Object> SchemaCache;

+ typedef v8::StdGlobalValueMap<std::string, v8::Object> SchemaCache;

scoped_ptr<SchemaCache> schema_cache_;

// Single per-instance gin::ContextHolder to create v8::Values.

« no previous file with comments | « content/renderer/pepper/plugin_object.h ('k') | gin/interceptor_unittest.cc » ('j') | no next file with comments »