Rename NetLogLogger and CapturingNetLog

Rename NetLogLogger and CapturingNetLog

Renaming two classes
CapturingNetLog --> TestNetLog
NetLogLogger --> WriteToFileNetLogObserver

BUG=473252
TBR=jam,mmenke

Committed: https://crrev.com/62985ca964bae26730280620d01a606eeff1d226
Cr-Commit-Position: refs/heads/master@{#325611}

[vishal.b, 2015-04-13 09:29:30]

vishal.b@samsung.com changed reviewers:
+ eroman@chromium.org

[vishal.b, 2015-04-13 09:29:30]

Please have a look and review the code.

[eroman, 2015-04-14 20:06:12]

https://codereview.chromium.org/1084533002/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/api/dial/dial_service_unittest.cc (right):

https://codereview.chromium.org/1084533002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/dial/dial_service_unittest.cc:52: net::TestNetLog
capturing_net_log_;
As a follow up, I would like to additionally rename variables. For instance
here:
  capturing_net_log_ --> test_net_log_

https://codereview.chromium.org/1084533002/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/api/log_private/log_private_api.h (right):

https://codereview.chromium.org/1084533002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/log_private/log_private_api.h:116:
scoped_ptr<net::WriteToFileNetLogObserver> net_log_logger_;
Same comment here. It is fine to start by renaming the class, and in fact that
is the approach I recommend.

However as a follow-up I would like for us to normalize the variable names to
match the new naming.

Perhaps here:
  net_log_logger_ --> write_to_file_observer_

https://codereview.chromium.org/1084533002/diff/1/net/log/test_net_log.h
File net/log/test_net_log.h (right):

https://codereview.chromium.org/1084533002/diff/1/net/log/test_net_log.h#newc...
net/log/test_net_log.h:5: #ifndef NET_LOG_CAPTURING_NET_LOG_H_
Update this ifdef:

NET_LOG_CAPTURING_NET_LOG_H_ --> NET_LOG_TEST_NET_LOG_H_

And throughout this file.

https://codereview.chromium.org/1084533002/diff/1/net/log/test_net_log.h#newc...
net/log/test_net_log.h:50: class CapturingBoundNetLog {
This should be renamed too, either as part of this change of independently.

Perhaps to --> BoundTestNetLog of TestNetLogForSource

https://codereview.chromium.org/1084533002/diff/1/net/log/write_to_file_net_l...
File net/log/write_to_file_net_log_observer.h (right):

https://codereview.chromium.org/1084533002/diff/1/net/log/write_to_file_net_l...
net/log/write_to_file_net_log_observer.h:5: #ifndef NET_LOG_NET_LOG_LOGGER_H_
Please update this to match the new filepath

https://codereview.chromium.org/1084533002/diff/1/net/log/write_to_file_net_l...
net/log/write_to_file_net_log_observer.h:26: // entries to
Join the previous line to here to match new wrapping.

https://codereview.chromium.org/1084533002/diff/1/net/log/write_to_file_net_l...
File net/log/write_to_file_net_log_observer_unittest.cc (right):

https://codereview.chromium.org/1084533002/diff/1/net/log/write_to_file_net_l...
net/log/write_to_file_net_log_observer_unittest.cc:25: class NetLogLoggerTest :
public testing::Test {
This should be renamed to:

    WriteToFileNetLogObserverTest

[vishal.b, 2015-04-15 07:33:55]

On 2015/04/14 20:06:12, eroman wrote:

Hi, 
I incorporated all the comments given by you.
Please review again.

[vishal.b, 2015-04-15 07:34:10]

On 2015/04/14 20:06:12, eroman wrote:

Hi, 
I incorporated all the comments given by you.
Please review again.

[eroman, 2015-04-15 15:54:39]

Patchset 2 LGTM.

[eroman, 2015-04-15 15:57:41]

Please update the CL description to reference the additional class that was
renamed.

You will also want to run "git cl owners"  to find OWNERs for the files outside
net/ to include on the review. It is acceptable to add these as TBR= and then
submit the change, since it is just renaming (and I have approved the net API
change).

[vishal.b, 2015-04-16 04:49:35]

vishal.b@samsung.com changed reviewers:
+ davidben@chromium.org, jam@chromium.org, mmenke@chromium.org

[vishal.b, 2015-04-16 04:49:37]

Please review the code.

[jam, 2015-04-16 14:49:37]

On 2015/04/16 04:49:37, vishal.b wrote:
> Please review the code.

what do you want me to review?

[eroman, 2015-04-16 19:14:39]

vishal.b is renaming some classes in net/, and I believe he added you following
"git cl owners", for rubber-stamp.

@vishal.b: You could use TBR= in this case to cover the files outside of net/.

[davidben, 2015-04-16 19:23:05]

Presuming I'm here for content/, content/ lgtm. I didn't look at net/, but I
assume eroman looked over that.

[vishal.b, 2015-04-17 05:23:28]

The CQ bit was checked by vishal.b@samsung.com

[commit-bot: I haz the power, 2015-04-17 05:23:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1084533002/20001

[commit-bot: I haz the power, 2015-04-17 05:48:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-17 05:48:04]

Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[vishal.b, 2015-04-17 07:47:01]

The CQ bit was checked by vishal.b@samsung.com

[vishal.b, 2015-04-17 07:47:02]

The patchset sent to the CQ was uploaded after l-g-t-m from eroman@chromium.org,
davidben@chromium.org
Link to the patchset: https://codereview.chromium.org/1084533002/#ps40001
(title: "Rename NetLogLogger and CapturingNetLog(removed compiler error for
chromeOS)")

[commit-bot: I haz the power, 2015-04-17 07:47:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1084533002/40001

[commit-bot: I haz the power, 2015-04-17 08:46:03]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-04-17 08:46:50]

Patchset 3 (id:??) landed as
https://crrev.com/62985ca964bae26730280620d01a606eeff1d226
Cr-Commit-Position: refs/heads/master@{#325611}

[vishal.b, 2015-04-22 08:53:03]

Patchset #4 (id:60001) has been deleted