chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc - Issue 1084533002: Rename NetLogLogger and CapturingNetLog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc

Issue 1084533002: Rename NetLogLogger and CapturingNetLog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rename NetLogLogger and CapturingNetLog(removed compiler error for chromeOS) Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/net_internals/net_internals_ui.cc ('k') | components/cronet/android/cronet_url_request_context_adapter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc

diff --git a/chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc b/chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc

index 76f11a9b1fc88f52db360f018644e87715ac11af..de6488ef1df889f25a809fa3f76243e0d770a695 100644

--- a/chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc

+++ b/chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc

@@ -37,7 +37,7 @@

#include "net/http/http_network_session.h"

#include "net/http/http_transaction_factory.h"

#include "net/log/net_log.h"

-#include "net/log/net_log_logger.h"

+#include "net/log/write_to_file_net_log_observer.h"

#include "net/url_request/url_request_context.h"

#include "net/url_request/url_request_context_getter.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -282,7 +282,8 @@ void NetInternalsTest::MessageHandler::GetNetLogLoggerLog(

ASSERT_TRUE(temp_file_handle);

scoped_ptr<base::Value> constants(NetInternalsUI::GetConstants());

- scoped_ptr<net::NetLogLogger> net_log_logger(new net::NetLogLogger());

+ scoped_ptr<net::WriteToFileNetLogObserver> net_log_logger(

+ new net::WriteToFileNetLogObserver());

net_log_logger->StartObserving(

g_browser_process->net_log(), temp_file_handle.Pass(), constants.get(),

nullptr);