Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(951)

Unified Diff: net/url_request/url_request_unittest.cc

Issue 1084533002: Rename NetLogLogger and CapturingNetLog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rename NetLogLogger and CapturingNetLog(removed compiler error for chromeOS) Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/udp/udp_socket_unittest.cc ('k') | net/websockets/websocket_basic_stream_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_unittest.cc
diff --git a/net/url_request/url_request_unittest.cc b/net/url_request/url_request_unittest.cc
index e86672c6b726829b084437edff72696abff23eff..5980904e8e6397f08406c3a5e0cbb18c035268cb 100644
--- a/net/url_request/url_request_unittest.cc
+++ b/net/url_request/url_request_unittest.cc
@@ -58,9 +58,9 @@
#include "net/http/http_request_headers.h"
#include "net/http/http_response_headers.h"
#include "net/http/http_util.h"
-#include "net/log/capturing_net_log.h"
#include "net/log/net_log.h"
#include "net/log/net_log_unittest.h"
+#include "net/log/test_net_log.h"
#include "net/proxy/proxy_service.h"
#include "net/socket/ssl_client_socket.h"
#include "net/ssl/ssl_cipher_suite_names.h"
@@ -651,7 +651,7 @@ class URLRequestTest : public PlatformTest {
}
protected:
- CapturingNetLog net_log_;
+ TestNetLog net_log_;
TestNetworkDelegate default_network_delegate_; // Must outlive URLRequest.
URLRequestJobFactoryImpl* job_factory_impl_;
scoped_ptr<URLRequestJobFactory> job_factory_;
@@ -4159,8 +4159,8 @@ class AsyncDelegateLogger : public base::RefCounted<AsyncDelegateLogger> {
// DELEGATE_INFO NetLog events that an AsyncDelegateLogger should have
// recorded. Returns the index of entry after the expected number of
// events this logged, or entries.size() if there aren't enough entries.
- static size_t CheckDelegateInfo(
- const CapturingNetLog::CapturedEntryList& entries, size_t log_position) {
+ static size_t CheckDelegateInfo(const TestNetLog::CapturedEntryList& entries,
+ size_t log_position) {
// There should be 4 DELEGATE_INFO events: Two begins and two ends.
if (log_position + 3 >= entries.size()) {
ADD_FAILURE() << "Not enough log entries";
@@ -4194,7 +4194,7 @@ class AsyncDelegateLogger : public base::RefCounted<AsyncDelegateLogger> {
// Find delegate request begin and end messages for OnBeforeNetworkStart.
// Returns the position of the end message.
static size_t ExpectBeforeNetworkEvents(
- const CapturingNetLog::CapturedEntryList& entries,
+ const TestNetLog::CapturedEntryList& entries,
size_t log_position) {
log_position =
ExpectLogContainsSomewhereAfter(entries,
@@ -4461,7 +4461,7 @@ TEST_F(URLRequestTestHTTP, DelegateInfoBeforeStart) {
EXPECT_EQ(URLRequestStatus::SUCCESS, r->status().status());
}
- CapturingNetLog::CapturedEntryList entries;
+ TestNetLog::CapturedEntryList entries;
net_log_.GetEntries(&entries);
size_t log_position = ExpectLogContainsSomewhereAfter(
entries,
@@ -4506,7 +4506,7 @@ TEST_F(URLRequestTestHTTP, NetworkDelegateInfo) {
EXPECT_EQ(1, network_delegate.destroyed_requests());
size_t log_position = 0;
- CapturingNetLog::CapturedEntryList entries;
+ TestNetLog::CapturedEntryList entries;
net_log_.GetEntries(&entries);
for (size_t i = 0; i < 3; ++i) {
log_position = ExpectLogContainsSomewhereAfter(
@@ -4563,7 +4563,7 @@ TEST_F(URLRequestTestHTTP, NetworkDelegateInfoRedirect) {
EXPECT_EQ(1, network_delegate.destroyed_requests());
size_t log_position = 0;
- CapturingNetLog::CapturedEntryList entries;
+ TestNetLog::CapturedEntryList entries;
net_log_.GetEntries(&entries);
// The NetworkDelegate logged information in OnBeforeURLRequest,
// OnBeforeSendHeaders, and OnHeadersReceived.
@@ -4645,7 +4645,7 @@ TEST_F(URLRequestTestHTTP, NetworkDelegateInfoAuth) {
EXPECT_EQ(1, network_delegate.destroyed_requests());
size_t log_position = 0;
- CapturingNetLog::CapturedEntryList entries;
+ TestNetLog::CapturedEntryList entries;
net_log_.GetEntries(&entries);
// The NetworkDelegate should have logged information in OnBeforeURLRequest,
// OnBeforeSendHeaders, OnHeadersReceived, OnAuthRequired, and then again in
@@ -4702,7 +4702,7 @@ TEST_F(URLRequestTestHTTP, URLRequestDelegateInfo) {
EXPECT_EQ(URLRequestStatus::SUCCESS, r->status().status());
}
- CapturingNetLog::CapturedEntryList entries;
+ TestNetLog::CapturedEntryList entries;
net_log_.GetEntries(&entries);
size_t log_position = 0;
@@ -4755,7 +4755,7 @@ TEST_F(URLRequestTestHTTP, URLRequestDelegateInfoOnRedirect) {
EXPECT_EQ(URLRequestStatus::SUCCESS, r->status().status());
}
- CapturingNetLog::CapturedEntryList entries;
+ TestNetLog::CapturedEntryList entries;
net_log_.GetEntries(&entries);
// Delegate info should only have been logged in OnReceivedRedirect and
@@ -4802,7 +4802,7 @@ TEST_F(URLRequestTestHTTP, URLRequestDelegateOnRedirectCancelled) {
++test_case) {
AsyncLoggingUrlRequestDelegate request_delegate(kCancelStages[test_case]);
TestURLRequestContext context(true);
- CapturingNetLog net_log;
+ TestNetLog net_log;
context.set_network_delegate(NULL);
context.set_net_log(&net_log);
context.Init();
@@ -4817,7 +4817,7 @@ TEST_F(URLRequestTestHTTP, URLRequestDelegateOnRedirectCancelled) {
EXPECT_EQ(URLRequestStatus::CANCELED, r->status().status());
}
- CapturingNetLog::CapturedEntryList entries;
+ TestNetLog::CapturedEntryList entries;
net_log.GetEntries(&entries);
// Delegate info is always logged in both OnReceivedRedirect and
@@ -7261,7 +7261,7 @@ TEST_F(HTTPSRequestTest, HTTPSExpiredTest) {
// Tests that servers which require a deprecated cipher suite still work.
TEST_F(HTTPSRequestTest, CipherFallbackTest) {
- CapturingNetLog net_log;
+ TestNetLog net_log;
default_context_.set_net_log(&net_log);
SpawnedTestServer::SSLOptions ssl_options;
@@ -7297,7 +7297,7 @@ TEST_F(HTTPSRequestTest, CipherFallbackTest) {
EXPECT_EQ(expected_version,
SSLConnectionStatusToVersion(r->ssl_info().connection_status));
- CapturingNetLog::CapturedEntryList entries;
+ TestNetLog::CapturedEntryList entries;
net_log.GetEntries(&entries);
ExpectLogContainsSomewhere(entries, 0, NetLog::TYPE_SSL_CIPHER_FALLBACK,
NetLog::PHASE_NONE);
« no previous file with comments | « net/udp/udp_socket_unittest.cc ('k') | net/websockets/websocket_basic_stream_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698