Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 1083323005: dbus/values_util_unittest.cc: use sqrt from cmath (Closed)

Created:
5 years, 8 months ago by hans
Modified:
5 years, 8 months ago
Reviewers:
Nico, satorux1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

dbus/values_util_unittest.cc: use sqrt from cmath This should fix the following error on an ASan Linux builder: ../../dbus/values_util_unittest.cc:360:15: error: use of undeclared identifier 'sqrt' keys[i] = sqrt(values[i]); ^ BUG=none R=thakis@chromium.org TBR=satorux

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M dbus/values_util_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
hans
This is the red build: http://build.chromium.org/p/chromium.fyi/builders/ClangToTLinuxASan/builds/924/ It seems to have regressed with: https://codereview.chromium.org/1076443002
5 years, 8 months ago (2015-04-24 21:00:06 UTC) #2
Nico
lgtm
5 years, 8 months ago (2015-04-24 21:11:26 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1083323005/1
5 years, 8 months ago (2015-04-24 21:14:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1083323005/1
5 years, 8 months ago (2015-04-24 21:37:35 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-24 21:40:46 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/721934941fee85b5dec2356f53c1de1cf172fbd5 Cr-Commit-Position: refs/heads/master@{#326882}
5 years, 8 months ago (2015-04-24 21:41:33 UTC) #10
hans
5 years, 8 months ago (2015-04-24 21:41:39 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) to pending queue manually as
dab69133f6954d56cb676693febb16618a2a4c77 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698