Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Side by Side Diff: dbus/values_util_unittest.cc

Issue 1083323005: dbus/values_util_unittest.cc: use sqrt from cmath (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "dbus/values_util.h" 5 #include "dbus/values_util.h"
6 6
7 #include <cmath>
7 #include <vector> 8 #include <vector>
8 9
9 #include "base/json/json_writer.h" 10 #include "base/json/json_writer.h"
10 #include "base/memory/scoped_ptr.h" 11 #include "base/memory/scoped_ptr.h"
11 #include "base/values.h" 12 #include "base/values.h"
12 #include "dbus/message.h" 13 #include "dbus/message.h"
13 #include "testing/gtest/include/gtest/gtest.h" 14 #include "testing/gtest/include/gtest/gtest.h"
14 15
15 namespace dbus { 16 namespace dbus {
16 17
(...skipping 333 matching lines...) Expand 10 before | Expand all | Expand 10 after
350 ASSERT_TRUE(value.get() != NULL); 351 ASSERT_TRUE(value.get() != NULL);
351 EXPECT_TRUE(value->Equals(&dictionary_value)); 352 EXPECT_TRUE(value->Equals(&dictionary_value));
352 } 353 }
353 354
354 TEST(ValuesUtilTest, PopDoubleToIntDictionary) { 355 TEST(ValuesUtilTest, PopDoubleToIntDictionary) {
355 // Create test data. 356 // Create test data.
356 const int32 kValues[] = {0, 1, 1, 2, 3, 5, 8, 13, 21}; 357 const int32 kValues[] = {0, 1, 1, 2, 3, 5, 8, 13, 21};
357 const std::vector<int32> values(kValues, kValues + arraysize(kValues)); 358 const std::vector<int32> values(kValues, kValues + arraysize(kValues));
358 std::vector<double> keys(values.size()); 359 std::vector<double> keys(values.size());
359 for (size_t i = 0; i != values.size(); ++i) 360 for (size_t i = 0; i != values.size(); ++i)
360 keys[i] = sqrt(values[i]); 361 keys[i] = std::sqrt(values[i]);
361 362
362 // Append a dictionary. 363 // Append a dictionary.
363 scoped_ptr<Response> response(Response::CreateEmpty()); 364 scoped_ptr<Response> response(Response::CreateEmpty());
364 MessageWriter writer(response.get()); 365 MessageWriter writer(response.get());
365 MessageWriter sub_writer(NULL); 366 MessageWriter sub_writer(NULL);
366 writer.OpenArray("{di}", &sub_writer); 367 writer.OpenArray("{di}", &sub_writer);
367 for (size_t i = 0; i != values.size(); ++i) { 368 for (size_t i = 0; i != values.size(); ++i) {
368 MessageWriter entry_writer(NULL); 369 MessageWriter entry_writer(NULL);
369 sub_writer.OpenDictEntry(&entry_writer); 370 sub_writer.OpenDictEntry(&entry_writer);
370 entry_writer.AppendDouble(keys[i]); 371 entry_writer.AppendDouble(keys[i]);
(...skipping 309 matching lines...) Expand 10 before | Expand all | Expand 10 after
680 scoped_ptr<base::Value> value; 681 scoped_ptr<base::Value> value;
681 value.reset(PopDataAsValue(&reader)); 682 value.reset(PopDataAsValue(&reader));
682 ASSERT_TRUE(value.get() != NULL); 683 ASSERT_TRUE(value.get() != NULL);
683 EXPECT_TRUE(value->Equals(&test_list)); 684 EXPECT_TRUE(value->Equals(&test_list));
684 value.reset(PopDataAsValue(&reader)); 685 value.reset(PopDataAsValue(&reader));
685 ASSERT_TRUE(value.get() != NULL); 686 ASSERT_TRUE(value.get() != NULL);
686 EXPECT_TRUE(value->Equals(&int_value)); 687 EXPECT_TRUE(value->Equals(&int_value));
687 } 688 }
688 689
689 } // namespace dbus 690 } // namespace dbus
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698