Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Side by Side Diff: Source/core/svg/SVGTests.cpp

Issue 108313015: Make calls to AtomicString(const String&) explicit in html/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Take feedback into consideration Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2008 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2008 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org>
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 unsigned featuresSize = m_requiredFeatures.value.size(); 103 unsigned featuresSize = m_requiredFeatures.value.size();
104 for (unsigned i = 0; i < featuresSize; ++i) { 104 for (unsigned i = 0; i < featuresSize; ++i) {
105 String value = m_requiredFeatures.value.at(i); 105 String value = m_requiredFeatures.value.at(i);
106 if (value.isEmpty() || !DOMImplementation::hasFeature(value, String())) 106 if (value.isEmpty() || !DOMImplementation::hasFeature(value, String()))
107 return false; 107 return false;
108 } 108 }
109 109
110 unsigned systemLanguageSize = m_systemLanguage.value.size(); 110 unsigned systemLanguageSize = m_systemLanguage.value.size();
111 for (unsigned i = 0; i < systemLanguageSize; ++i) { 111 for (unsigned i = 0; i < systemLanguageSize; ++i) {
112 String value = m_systemLanguage.value.at(i); 112 String value = m_systemLanguage.value.at(i);
113 if (value != defaultLanguage().substring(0, 2)) 113 if (value != defaultLanguage().string().substring(0, 2))
eseidel 2014/01/02 19:18:28 AtomicString might need substring() too. not sure
114 return false; 114 return false;
115 } 115 }
116 116
117 if (!m_requiredExtensions.value.isEmpty()) 117 if (!m_requiredExtensions.value.isEmpty())
118 return false; 118 return false;
119 119
120 return true; 120 return true;
121 } 121 }
122 122
123 bool SVGTests::parseAttribute(const QualifiedName& name, const AtomicString& val ue) 123 bool SVGTests::parseAttribute(const QualifiedName& name, const AtomicString& val ue)
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
191 return m_requiredExtensions.value; 191 return m_requiredExtensions.value;
192 } 192 }
193 193
194 SVGStringList& SVGTests::systemLanguage() 194 SVGStringList& SVGTests::systemLanguage()
195 { 195 {
196 m_systemLanguage.shouldSynchronize = true; 196 m_systemLanguage.shouldSynchronize = true;
197 return m_systemLanguage.value; 197 return m_systemLanguage.value;
198 } 198 }
199 199
200 } 200 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698