Source/core/html/track/vtt/VTTCue.cpp - Issue 108313015: Make calls to AtomicString(const String&) explicit in html/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/track/vtt/VTTCue.cpp

Issue 108313015: Make calls to AtomicString(const String&) explicit in html/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Take feedback into consideration Created 6 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/html/parser/AtomicHTMLToken.h ('K') | « Source/core/html/track/TextTrackCueList.cpp ('k') | Source/core/html/track/vtt/VTTParser.h » ('j') | Source/core/svg/SVGTests.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/track/vtt/VTTCue.cpp

diff --git a/Source/core/html/track/vtt/VTTCue.cpp b/Source/core/html/track/vtt/VTTCue.cpp

index 15412ea2158dd1488c59fc33abfd47ec8a6bd8ec..2be7b1156494b42ed321e4215bf07308d0b15284 100644

--- a/Source/core/html/track/vtt/VTTCue.cpp

+++ b/Source/core/html/track/vtt/VTTCue.cpp

@@ -226,7 +226,7 @@ VTTCue::~VTTCue()

#ifndef NDEBUG

String VTTCue::toString() const

{

- return String::format("%p id=%s interval=%f-->%f cue=%s)", this, id().utf8().data(), startTime(), endTime(), text().utf8().data());

+ return String::format("%p id=%s interval=%f-->%f cue=%s)", this, id().string().utf8().data(), startTime(), endTime(), text().utf8().data());

}

#endif

« Source/core/html/parser/AtomicHTMLToken.h ('K') | « Source/core/html/track/TextTrackCueList.cpp ('k') | Source/core/html/track/vtt/VTTParser.h » ('j') | Source/core/svg/SVGTests.cpp » ('J')