Source/core/html/HTMLViewSourceDocument.h - Issue 108313015: Make calls to AtomicString(const String&) explicit in html/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLViewSourceDocument.h

Issue 108313015: Make calls to AtomicString(const String&) explicit in html/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Take feedback into consideration Created 6 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/html/HTMLMediaElement.cpp ('K') | « Source/core/html/HTMLVideoElement.cpp ('k') | Source/core/html/HTMLViewSourceDocument.cpp » ('j') | Source/core/html/parser/AtomicHTMLToken.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLViewSourceDocument.h

diff --git a/Source/core/html/HTMLViewSourceDocument.h b/Source/core/html/HTMLViewSourceDocument.h

index a1988cc7e2c3af8480587b7903e0ee399a15da38..8c2608a67d7c7aab3a0d44b14f6927f03781eda6 100644

--- a/Source/core/html/HTMLViewSourceDocument.h

+++ b/Source/core/html/HTMLViewSourceDocument.h

@@ -58,7 +58,7 @@ private:

void addLine(const AtomicString& className);

void finishLine();

void addText(const String& text, const AtomicString& className);

- int addRange(const String& source, int start, int end, const String& className, bool isLink = false, bool isAnchor = false, const String& link = String());

+ int addRange(const String& source, int start, int end, const AtomicString& className, bool isLink = false, bool isAnchor = false, const AtomicString& link = nullAtom);

eseidel 2014/01/02 19:18:28 Bools as arguments are sooooo bad. We really need

PassRefPtr<Element> addLink(const AtomicString& url, bool isAnchor);

PassRefPtr<Element> addBase(const AtomicString& href);