Source/core/html/forms/FileInputType.cpp - Issue 108313015: Make calls to AtomicString(const String&) explicit in html/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/forms/FileInputType.cpp

Issue 108313015: Make calls to AtomicString(const String&) explicit in html/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Take feedback into consideration Created 6 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/html/HTMLViewSourceDocument.h ('K') | « Source/core/html/HTMLViewSourceDocument.cpp ('k') | Source/core/html/forms/FormController.cpp » ('j') | Source/core/html/parser/AtomicHTMLToken.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/forms/FileInputType.cpp

diff --git a/Source/core/html/forms/FileInputType.cpp b/Source/core/html/forms/FileInputType.cpp

index d8655ae2a03dcac6739abee278acc46ac6f6f64e..d3ae7c931cf42ef622ab1378a4203c5f1aa4f6df 100644

--- a/Source/core/html/forms/FileInputType.cpp

+++ b/Source/core/html/forms/FileInputType.cpp

@@ -249,7 +249,7 @@ void FileInputType::createShadowSubtree()

ASSERT(element().shadow());

RefPtr<HTMLInputElement> button = HTMLInputElement::create(element().document(), 0, false);

button->setType(InputTypeNames::button);

- button->setAttribute(valueAttr, locale().queryString(element().multiple() ? WebLocalizedString::FileButtonChooseMultipleFilesLabel : WebLocalizedString::FileButtonChooseFileLabel));

+ button->setAttribute(valueAttr, AtomicString(locale().queryString(element().multiple() ? WebLocalizedString::FileButtonChooseMultipleFilesLabel : WebLocalizedString::FileButtonChooseFileLabel)));

button->setShadowPseudoId(AtomicString("-webkit-file-upload-button", AtomicString::ConstructFromLiteral));

element().userAgentShadowRoot()->appendChild(button.release());

}

@@ -265,7 +265,7 @@ void FileInputType::multipleAttributeChanged()

{

ASSERT(element().shadow());

if (Element* button = toElement(element().userAgentShadowRoot()->firstChild()))

- button->setAttribute(valueAttr, locale().queryString(element().multiple() ? WebLocalizedString::FileButtonChooseMultipleFilesLabel : WebLocalizedString::FileButtonChooseFileLabel));

+ button->setAttribute(valueAttr, AtomicString(locale().queryString(element().multiple() ? WebLocalizedString::FileButtonChooseMultipleFilesLabel : WebLocalizedString::FileButtonChooseFileLabel)));

}

void FileInputType::setFiles(PassRefPtr<FileList> files)