Source/core/html/HTMLInputElement.cpp - Issue 108313015: Make calls to AtomicString(const String&) explicit in html/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLInputElement.cpp

Issue 108313015: Make calls to AtomicString(const String&) explicit in html/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Take feedback into consideration Created 6 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/html/HTMLFrameElementBase.cpp ('K') | « Source/core/html/HTMLImageElement.cpp ('k') | Source/core/html/HTMLMapElement.cpp » ('j') | Source/core/html/HTMLMediaElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLInputElement.cpp

diff --git a/Source/core/html/HTMLInputElement.cpp b/Source/core/html/HTMLInputElement.cpp

index b41a6f1f819f49552ec90f372ff7418793627cf1..0b96aa6bf46ce3a9ba7d9216cbb2204c26956cb6 100644

--- a/Source/core/html/HTMLInputElement.cpp

+++ b/Source/core/html/HTMLInputElement.cpp

@@ -1804,7 +1804,7 @@ bool HTMLInputElement::setupDateTimeChooserParameters(DateTimeChooserParameters&

parameters.locale = defaultLanguage();

else {

AtomicString computedLocale = computeInheritedLanguage();

- parameters.locale = computedLocale.isEmpty() ? AtomicString(defaultLanguage()) : computedLocale;

+ parameters.locale = computedLocale.isEmpty() ? defaultLanguage() : computedLocale;

}

StepRange stepRange = createStepRange(RejectAny);

« Source/core/html/HTMLFrameElementBase.cpp ('K') | « Source/core/html/HTMLImageElement.cpp ('k') | Source/core/html/HTMLMapElement.cpp » ('j') | Source/core/html/HTMLMediaElement.cpp » ('J')