Source/core/html/HTMLFrameElementBase.cpp - Issue 108313015: Make calls to AtomicString(const String&) explicit in html/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLFrameElementBase.cpp

Issue 108313015: Make calls to AtomicString(const String&) explicit in html/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Take feedback into consideration Created 6 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLFrameElementBase.cpp

diff --git a/Source/core/html/HTMLFrameElementBase.cpp b/Source/core/html/HTMLFrameElementBase.cpp

index fc6bfb98c359fdc672ec04e415689bc1cca438c5..afc9ec57ecb071991be33a40b9d5ecb66dbc698e 100644

--- a/Source/core/html/HTMLFrameElementBase.cpp

+++ b/Source/core/html/HTMLFrameElementBase.cpp

@@ -76,7 +76,7 @@ void HTMLFrameElementBase::openURL(bool lockBackForwardList)

return;

if (m_URL.isEmpty())

- m_URL = blankURL().string();

+ m_URL = AtomicString(blankURL().string());

eseidel 2014/01/02 19:18:28 I guess you're adding KURL::toAtomicString() in a

Inactive 2014/01/02 19:34:07 Yes, this is on my TODO list.

Frame* parentFrame = document().frame();

if (!parentFrame)

« no previous file with comments | « Source/core/html/HTMLAudioElement.cpp ('k') | Source/core/html/HTMLImageElement.cpp » ('j') | Source/core/html/HTMLMediaElement.cpp » ('J')