Source/core/html/HTMLImageElement.cpp - Issue 108313015: Make calls to AtomicString(const String&) explicit in html/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLImageElement.cpp

Issue 108313015: Make calls to AtomicString(const String&) explicit in html/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Take feedback into consideration Created 6 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/html/HTMLFrameElementBase.cpp ('K') | « Source/core/html/HTMLFrameElementBase.cpp ('k') | Source/core/html/HTMLInputElement.cpp » ('j') | Source/core/html/HTMLMediaElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLImageElement.cpp

diff --git a/Source/core/html/HTMLImageElement.cpp b/Source/core/html/HTMLImageElement.cpp

index 8698048bcb0e71fb2e8e3a223b9f907a784d47af..6a48fcdef743ccbab7dd8c8a584c97d30cd0f571 100644

--- a/Source/core/html/HTMLImageElement.cpp

+++ b/Source/core/html/HTMLImageElement.cpp

@@ -127,7 +127,7 @@ void HTMLImageElement::parseAttribute(const QualifiedName& name, const AtomicStr

} else if (name == srcAttr || name == srcsetAttr) {

if (RuntimeEnabledFeatures::srcsetEnabled()) {

ImageCandidate candidate = bestFitSourceForImageAttributes(document().devicePixelRatio(), fastGetAttribute(srcAttr), fastGetAttribute(srcsetAttr));

- m_bestFitImageURL = candidate.toString();

+ m_bestFitImageURL = candidate.toAtomicString();

float candidateScaleFactor = candidate.scaleFactor();

if (candidateScaleFactor > 0)

m_imageDevicePixelRatio = 1 / candidateScaleFactor;