Source/core/html/HTMLAudioElement.cpp - Issue 108313015: Make calls to AtomicString(const String&) explicit in html/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLAudioElement.cpp

Issue 108313015: Make calls to AtomicString(const String&) explicit in html/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Take feedback into consideration Created 6 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLAudioElement.cpp

diff --git a/Source/core/html/HTMLAudioElement.cpp b/Source/core/html/HTMLAudioElement.cpp

index bdc0d9f3a04fc64c798645dab34d1b044bbb08d1..b1993bc85178fbc34678ac8c133c2cd2b7e05a98 100644

--- a/Source/core/html/HTMLAudioElement.cpp

+++ b/Source/core/html/HTMLAudioElement.cpp

@@ -48,7 +48,7 @@ PassRefPtr<HTMLAudioElement> HTMLAudioElement::create(Document& document, bool c

PassRefPtr<HTMLAudioElement> HTMLAudioElement::createForJSConstructor(Document& document, const AtomicString& src)

{

RefPtr<HTMLAudioElement> audio = adoptRef(new HTMLAudioElement(document, false));

- audio->setPreload("auto");

+ audio->setPreload(AtomicString("auto", AtomicString::ConstructFromLiteral));

if (!src.isNull())

audio->setSrc(src);

audio->suspendIfNeeded();

« no previous file with comments | « Source/core/html/HTMLAnchorElement.cpp ('k') | Source/core/html/HTMLFrameElementBase.cpp » ('j') | Source/core/html/HTMLFrameElementBase.cpp » ('J')