Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Unified Diff: Source/core/html/HTMLAnchorElement.cpp

Issue 108313015: Make calls to AtomicString(const String&) explicit in html/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Take feedback into consideration Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLAnchorElement.cpp
diff --git a/Source/core/html/HTMLAnchorElement.cpp b/Source/core/html/HTMLAnchorElement.cpp
index 0b890810acf2d98b5cc719d3c15f2d4aab39b0d1..daed2076f1bb8050bbf3baf7e62b04a3ad4538b9 100644
--- a/Source/core/html/HTMLAnchorElement.cpp
+++ b/Source/core/html/HTMLAnchorElement.cpp
@@ -346,7 +346,7 @@ String HTMLAnchorElement::input() const
void HTMLAnchorElement::setInput(const String& value)
{
- setHref(value);
+ setHref(AtomicString(value));
}
bool HTMLAnchorElement::hasRel(uint32_t relation) const
@@ -354,7 +354,7 @@ bool HTMLAnchorElement::hasRel(uint32_t relation) const
return m_linkRelations & relation;
}
-void HTMLAnchorElement::setRel(const String& value)
+void HTMLAnchorElement::setRel(const AtomicString& value)
{
m_linkRelations = 0;
SpaceSplitString newLinkRelations(value, true);
@@ -424,7 +424,7 @@ void HTMLAnchorElement::handleClick(Event* event)
if (!hasRel(RelationNoReferrer)) {
String referrer = SecurityPolicy::generateReferrerHeader(document().referrerPolicy(), completedURL, document().outgoingReferrer());
if (!referrer.isEmpty())
- request.setHTTPReferrer(referrer);
+ request.setHTTPReferrer(AtomicString(referrer));
}
frame->loader().client()->loadURLExternally(request, NavigationPolicyDownload, fastGetAttribute(downloadAttr));

Powered by Google App Engine
This is Rietveld 408576698