Prevent delivery of tab release key events while alt tabbing.

Prevent delivery of tab release key events while alt tabbing.

BUG=340339
TEST=WindowCycleControllerTest.TabKeyNotLeaked

Committed: https://crrev.com/41c0eca63206f880cf3b498520e22e1d2c16c196
Cr-Commit-Position: refs/heads/master@{#396924}

[flackr, 2015-04-22 18:58:57]

flackr@chromium.org changed reviewers:
+ jonross@chromium.org

[flackr, 2015-04-22 19:00:19]

PTAL, thanks!

[jonross, 2015-04-22 21:38:32]

On 2015/04/22 19:00:19, flackr wrote:
> PTAL, thanks!

LGTM

[flackr, 2016-05-30 20:49:29]

flackr@chromium.org changed reviewers:
+ sadrul@chromium.org

[flackr, 2016-05-30 20:49:30]

+sadrul, what do you think about just landing this simpler patch which
intentionally only changes the ChromeOS window manager behavior and doesn't
attempt to change chrome behavior? Not sending the tab keypresses during Alt+Tab
switching is consistent with Windows and Linux but ctrl+tab switching is much
less consistent and as a result contentious.

[sadrul, 2016-05-30 23:10:24]

On 2016/05/30 20:49:30, flackr wrote:
> +sadrul, what do you think about just landing this simpler patch which
> intentionally only changes the ChromeOS window manager behavior and doesn't
> attempt to change chrome behavior? Not sending the tab keypresses during
Alt+Tab
> switching is consistent with Windows and Linux but ctrl+tab switching is much
> less consistent and as a result contentious.

Sounds reasonable to me (although maybe WindowCycleController should be
consuming more/all key events ... is there a reason to send any key-event to the
window while alt-tabbing at all?)

PS: also, what year is it

[flackr, 2016-05-31 18:26:12]

On 2016/05/30 at 23:10:24, sadrul wrote:
> On 2016/05/30 20:49:30, flackr wrote:
> > +sadrul, what do you think about just landing this simpler patch which
> > intentionally only changes the ChromeOS window manager behavior and doesn't
> > attempt to change chrome behavior? Not sending the tab keypresses during
Alt+Tab
> > switching is consistent with Windows and Linux but ctrl+tab switching is
much
> > less consistent and as a result contentious.
> 
> Sounds reasonable to me (although maybe WindowCycleController should be
consuming more/all key events ... is there a reason to send any key-event to the
window while alt-tabbing at all?)

Makes sense, this will make ChromeOS consistent with most other OS alt+tab
behavior. Done.
> 
> PS: also, what year is it

12th, May, 1984... (http://www.imdb.com/title/tt0088247/quotes?item=qt0434603)

[sadrul, 2016-05-31 18:30:13]

lgtm

[flackr, 2016-05-31 19:33:59]

The CQ bit was checked by flackr@chromium.org

[flackr, 2016-05-31 19:33:59]

The patchset sent to the CQ was uploaded after l-g-t-m from jonross@chromium.org
Link to the patchset: https://codereview.chromium.org/1083093006/#ps20001
(title: "Handle all key events during alt tab window cycling.")

[commit-bot: I haz the power, 2016-05-31 19:34:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1083093006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1083093006/20001

[commit-bot: I haz the power, 2016-05-31 20:55:55]

Description was changed from

==========
Prevent delivery of tab release key events while alt tabbing.

BUG=340339
TEST=WindowCycleControllerTest.TabKeyNotLeaked
==========

to

==========
Prevent delivery of tab release key events while alt tabbing.

BUG=340339
TEST=WindowCycleControllerTest.TabKeyNotLeaked
==========

[commit-bot: I haz the power, 2016-05-31 20:55:56]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-31 20:57:10]

Description was changed from

==========
Prevent delivery of tab release key events while alt tabbing.

BUG=340339
TEST=WindowCycleControllerTest.TabKeyNotLeaked
==========

to

==========
Prevent delivery of tab release key events while alt tabbing.

BUG=340339
TEST=WindowCycleControllerTest.TabKeyNotLeaked

Committed: https://crrev.com/41c0eca63206f880cf3b498520e22e1d2c16c196
Cr-Commit-Position: refs/heads/master@{#396924}
==========

[commit-bot: I haz the power, 2016-05-31 20:57:11]

Patchset 2 (id:??) landed as
https://crrev.com/41c0eca63206f880cf3b498520e22e1d2c16c196
Cr-Commit-Position: refs/heads/master@{#396924}