Prevent delivery of tab release key events while alt tabbing.

ash/wm/window_cycle_controller_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/window_cycle_controller.h"
 
 #include <algorithm>
 #include <memory>
 
 #include "ash/session/session_state_delegate.h"
 #include "ash/shelf/shelf.h"
 #include "ash/shelf/shelf_widget.h"
 #include "ash/shell.h"
 #include "ash/shell_window_ids.h"
 #include "ash/test/ash_test_base.h"
 #include "ash/test/shelf_test_api.h"
 #include "ash/test/shelf_view_test_api.h"
 #include "ash/test/test_shelf_delegate.h"
 #include "ash/test/test_shell_delegate.h"
 #include "ash/wm/common/window_state.h"
 #include "ash/wm/window_cycle_list.h"
 #include "ash/wm/window_state_aura.h"
 #include "ash/wm/window_util.h"
 #include "ui/aura/client/aura_constants.h"
 #include "ui/aura/client/screen_position_client.h"
 #include "ui/aura/env.h"
 #include "ui/aura/test/test_windows.h"
 #include "ui/aura/window.h"
 #include "ui/aura/window_event_dispatcher.h"
+#include "ui/events/event_handler.h"
+#include "ui/events/test/event_generator.h"
 #include "ui/gfx/geometry/rect.h"
 
 namespace ash {
 
+namespace {
+
+class KeyEventCounter : public ui::EventHandler {
+ public:
+  KeyEventCounter() : key_events_(0) {}
+  ~KeyEventCounter() override {}
+
+  size_t GetCountAndReset() {
+    size_t count = key_events_;
+    key_events_ = 0;
+    return count;
+  }
+
+  // ui::EventHandler:
+  void OnKeyEvent(ui::KeyEvent* event) override { key_events_++; }
+
+ private:
+  size_t key_events_;
+
+  DISALLOW_COPY_AND_ASSIGN(KeyEventCounter);
+};
+
+}  // namespace
+
 using aura::test::CreateTestWindowWithId;
 using aura::test::TestWindowDelegate;
 using aura::Window;
 
 class WindowCycleControllerTest : public test::AshTestBase {
  public:
   WindowCycleControllerTest() {}
   ~WindowCycleControllerTest() override {}
 
   void SetUp() override {
@@ skipping 539 matching lines @@
 
   // Panel 1 is the next item as the MRU panel, removing it should make panel 2
   // the next window to be selected.
   panel0.reset();
   // Cycling again should now select panel1.
   controller->HandleCycleWindow(WindowCycleController::FORWARD);
   controller->StopCycling();
   EXPECT_TRUE(wm::IsActiveWindow(panel1.get()));
 }
 
+// Tests that the tab key events are not sent to the window.
+TEST_F(WindowCycleControllerTest, TabKeyNotLeaked) {
+  std::unique_ptr<Window> w0(CreateTestWindowInShellWithId(0));
+  std::unique_ptr<Window> w1(CreateTestWindowInShellWithId(1));
+  KeyEventCounter key_count;
+  w0->AddPreTargetHandler(&key_count);
+  w1->AddPreTargetHandler(&key_count);
+  ui::test::EventGenerator& generator = GetEventGenerator();
+  wm::GetWindowState(w0.get())->Activate();
+  generator.PressKey(ui::VKEY_MENU, ui::EF_NONE);
+  EXPECT_EQ(1u, key_count.GetCountAndReset());
+  generator.PressKey(ui::VKEY_TAB, ui::EF_ALT_DOWN);
+  EXPECT_EQ(0u, key_count.GetCountAndReset());
+  generator.ReleaseKey(ui::VKEY_TAB, ui::EF_ALT_DOWN);
+  EXPECT_EQ(0u, key_count.GetCountAndReset());
+  generator.ReleaseKey(ui::VKEY_MENU, ui::EF_NONE);
+  EXPECT_TRUE(wm::GetWindowState(w1.get())->IsActive());
+  EXPECT_EQ(0u, key_count.GetCountAndReset());
+}
+
 }  // namespace ash