ash/wm/window_cycle_controller.cc - Issue 1083093006: Prevent delivery of tab release key events while alt tabbing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/wm/window_cycle_controller.cc

Issue 1083093006: Prevent delivery of tab release key events while alt tabbing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Handle all key events during alt tab window cycling. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/wm/window_cycle_controller.cc

diff --git a/ash/wm/window_cycle_controller.cc b/ash/wm/window_cycle_controller.cc

index ca58f04fe7340a2b3fb456a63bd42b0ba0a387d4..12d880f0d2e66026e920dee741e8bae5c2fb8585 100644

--- a/ash/wm/window_cycle_controller.cc

+++ b/ash/wm/window_cycle_controller.cc

@@ -47,6 +47,9 @@ WindowCycleEventFilter::~WindowCycleEventFilter() {

}

void WindowCycleEventFilter::OnKeyEvent(ui::KeyEvent* event) {

+ // Until the alt key is released, all key events are handled by this window

+ // cycle controller: https://crbug.com/340339.

+ event->StopPropagation();

// Views uses VKEY_MENU for both left and right Alt keys.

if (event->key_code() == ui::VKEY_MENU &&

event->type() == ui::ET_KEY_RELEASED) {

« no previous file with comments | « no previous file | ash/wm/window_cycle_controller_unittest.cc » ('j') | no next file with comments »