Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 108293003: Revert 241705 "Revert 241681 "Let test_isolation_mode default to..." (Closed)

Created:
7 years ago by Nico
Modified:
7 years ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 241705 "Revert 241681 "Let test_isolation_mode default to..." This relands 241681, which should now hopefully work after r241717. > Revert 241681 "Let test_isolation_mode default to check on mac." > > Still not working on the branded builders, lots of .isolate files still > hardcode "chromium framework" (see http://crbug.com/324911) > > > Let test_isolation_mode default to check on mac. > > > > It was set to noop in https://chromiumcodereview.appspot.com/14055005 due to > > issues with xcode. Now that xcode is no longer used, it can be set to check > > again. > > > > BUG=none > > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238025 > > > > R=maruel@chromium.org > > > > Review URL: https://codereview.chromium.org/92303002 > > TBR=thakis@chromium.org > > Review URL: https://codereview.chromium.org/110423005 TBR=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241767

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M trunk/src/build/common.gypi View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Nico
7 years ago (2013-12-19 02:38:54 UTC) #1
Nico
7 years ago (2013-12-19 02:39:11 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r241767.

Powered by Google App Engine
This is Rietveld 408576698