Issue 110423005: Revert 241681 "Let test_isolation_mode default to check on mac."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 110423005: Revert 241681 "Let test_isolation_mode default to check on mac." (Closed)

Created:
7 years ago by Nico

Modified:
7 years ago

Reviewers:
Nico

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 241681 "Let test_isolation_mode default to check on mac." Still not working on the branded builders, lots of .isolate files still hardcode "chromium framework" (see http://crbug.com/324911) > Let test_isolation_mode default to check on mac. > > It was set to noop in https://chromiumcodereview.appspot.com/14055005 due to > issues with xcode. Now that xcode is no longer used, it can be set to check > again. > > BUG=none > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238025 > > R=maruel@chromium.org > > Review URL: https://codereview.chromium.org/92303002 TBR=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241705

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	trunk/src/build/common.gypi	View		1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r241705.