[6] Moves CreateVersionFromString to plugin_utils and updates the callers.

webkit/plugins/webplugininfo.h

Index: webkit/plugins/webplugininfo.h
diff --git a/webkit/plugins/webplugininfo.h b/webkit/plugins/webplugininfo.h
index cc09f7804915cddb667b439766bd8c90e6907fb7..89a92ec3b7f9a26b1d767d08c1840f57eea7e574 100644
--- a/webkit/plugins/webplugininfo.h
+++ b/webkit/plugins/webplugininfo.h
@@ -10,6 +10,7 @@
 
 #include "base/basictypes.h"
 #include "base/file_path.h"
+#include "base/version.h"
 #include "webkit/plugins/webkit_plugins_export.h"
 
 namespace webkit {
@@ -57,6 +58,11 @@ struct WEBKIT_PLUGINS_EXPORT WebPluginInfo {
                 const string16& fake_version,
                 const string16& fake_desc);
 
+  // Parse a version string as used by a plug-in. This method is more lenient
+  // in accepting weird version strings than Version::GetFromString().
+  static void CreateVersionFromString(const string16& version_string,

[jam, 2012/08/29 22:26:13]

a struct shouldn't have member functions per the style guide. it also doesn't
seem to belong on WebPluginInfo.

[ibraaaa, 2012/08/30 08:08:48]

It used to be in PluginGroup but we are doing this modification to remove
PluginGroup. I see your point, what do you suggest?

On 2012/08/29 22:26:13, John Abd-El-Malek wrote:

+                                      Version* version);
+
   // The name of the plugin (i.e. Flash).
   string16 name;