webkit/plugins/npapi/webplugin_delegate_impl_win.cc - Issue 10823434: [6] Moves CreateVersionFromString to plugin_utils and updates the callers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/plugins/npapi/webplugin_delegate_impl_win.cc

Issue 10823434: [6] Moves CreateVersionFromString to plugin_utils and updates the callers. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Modifications to move CreateVersionFromString to WebPluginInfo Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webkit/plugins/npapi/webplugin_delegate_impl_win.cc

diff --git a/webkit/plugins/npapi/webplugin_delegate_impl_win.cc b/webkit/plugins/npapi/webplugin_delegate_impl_win.cc

index a0a4f188ab560a7a3487fce3f22346c3a34487a4..bf3fd100e4ca122850672f7edf041b13612c7b3d 100644

--- a/webkit/plugins/npapi/webplugin_delegate_impl_win.cc

+++ b/webkit/plugins/npapi/webplugin_delegate_impl_win.cc

@@ -256,7 +256,7 @@ std::wstring GetKeyPath(HKEY key) {

int GetPluginMajorVersion(const WebPluginInfo& plugin_info) {

Version plugin_version;

- PluginGroup::CreateVersionFromString(plugin_info.version, &plugin_version);

+ WebPluginInfo::CreateVersionFromString(plugin_info.version, &plugin_version);

int major_version = 0;

if (plugin_version.IsValid())

« no previous file with comments | « content/utility/utility_thread_impl.cc ('k') | webkit/plugins/webplugininfo.h » ('j') | webkit/plugins/webplugininfo.h » ('J')