[6] Moves CreateVersionFromString to plugin_utils and updates the callers.

webkit/plugins/webplugininfo.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_PLUGINS_WEBPLUGININFO_H_
 #define WEBKIT_PLUGINS_WEBPLUGININFO_H_
 
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/file_path.h"
+#include "base/version.h"
 #include "webkit/plugins/webkit_plugins_export.h"
 
 namespace webkit {
 
 struct WEBKIT_PLUGINS_EXPORT WebPluginMimeType {
   WebPluginMimeType();
   // A constructor for the common case of a single file extension and an ASCII
   // description.
   WebPluginMimeType(const std::string& m,
                     const std::string& f,
@@ skipping 27 matching lines @@
   WebPluginInfo(const WebPluginInfo& rhs);
   ~WebPluginInfo();
   WebPluginInfo& operator=(const WebPluginInfo& rhs);
 
   // Special constructor only used during unit testing:
   WebPluginInfo(const string16& fake_name,
                 const FilePath& fake_path,
                 const string16& fake_version,
                 const string16& fake_desc);
 
+  // Parse a version string as used by a plug-in. This method is more lenient
+  // in accepting weird version strings than Version::GetFromString().
+  static void CreateVersionFromString(const string16& version_string,

[jam, 2012/08/29 22:26:13]

a struct shouldn't have member functions per the style guide. it also doesn't
seem to belong on WebPluginInfo.

[ibraaaa, 2012/08/30 08:08:48]

It used to be in PluginGroup but we are doing this modification to remove
PluginGroup. I see your point, what do you suggest?

On 2012/08/29 22:26:13, John Abd-El-Malek wrote:

+                                      Version* version);
+
   // The name of the plugin (i.e. Flash).
   string16 name;
 
   // The path to the plugin file (DLL/bundle/library).
   FilePath path;
 
   // The version number of the plugin file (may be OS-specific)
   string16 version;
 
   // A description of the plugin that we get from its version info.
@@ skipping 10 matching lines @@
 };
 
 // Checks whether a plugin is a Pepper plugin, enabled or disabled.
 WEBKIT_PLUGINS_EXPORT bool IsPepperPlugin(const WebPluginInfo& plugin);
 
 WEBKIT_PLUGINS_EXPORT bool IsOutOfProcessPlugin(const WebPluginInfo& plugin);
 
 }  // namespace webkit
 
 #endif  // WEBKIT_PLUGINS_WEBPLUGININFO_H_