Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 10823097: Part 2: Plumb render view ID to content::MediaObserver (Closed)

Created:
8 years, 4 months ago by sail
Modified:
8 years, 1 month ago
CC:
chromium-reviews, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, arv (Not doing code reviews), jam, darin-cc_chromium.org
Visibility:
Public.

Description

Part 2: Plumb render view ID to content::MediaObserver This is part 2 of the work to add audio indicator to tabs. This CL plubms the render view ID from render host to the browser. chrome://media-internals now shows tab titles next to each audio stream. BUG=64215 TEST=Go to a website playing audio. Open chrome://media-internals and verify that tab titles are displayed.

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -90 lines) Patch
M chrome/browser/media/media_internals.h View 1 3 chunks +17 lines, -9 lines 0 comments Download
M chrome/browser/media/media_internals.cc View 1 4 chunks +55 lines, -20 lines 0 comments Download
M chrome/browser/media/media_internals_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/media_internals/media_internals.js View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host.h View 1 3 chunks +7 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host.cc View 1 8 chunks +40 lines, -20 lines 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host_unittest.cc View 1 8 chunks +15 lines, -13 lines 0 comments Download
M content/browser/renderer_host/media/mock_media_observer.h View 1 1 chunk +11 lines, -8 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/public/browser/media_observer.h View 1 1 chunk +12 lines, -4 lines 0 comments Download
M content/renderer/media/webrtc_audio_device_unittest.cc View 1 4 chunks +19 lines, -12 lines 0 comments Download
M content/test/webrtc_audio_device_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
sail
8 years, 4 months ago (2012-07-31 06:46:49 UTC) #1
tommi (sloooow) - chröme
Great stuff. I see Chris' point on now passing three ids to all the functions ...
8 years, 4 months ago (2012-07-31 10:21:43 UTC) #2
sail
Rebased on top of changes to part 1. Note, I removed the "void* host" argument. ...
8 years, 4 months ago (2012-08-01 00:04:48 UTC) #3
tommi (sloooow) - chröme
8 years, 4 months ago (2012-08-01 11:10:41 UTC) #4
thanks for the update.  looks better with the host pointer removed.

Powered by Google App Engine
This is Rietveld 408576698