Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: chrome/browser/media/media_internals.h

Issue 10823097: Part 2: Plumb render view ID to content::MediaObserver (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/media/media_internals.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media/media_internals.h
diff --git a/chrome/browser/media/media_internals.h b/chrome/browser/media/media_internals.h
index 1edd86a1e592c197a3ebb75d0c27792cb00e068f..f449a2bb8ae0ac97a7472f93019e292dcacf80f0 100644
--- a/chrome/browser/media/media_internals.h
+++ b/chrome/browser/media/media_internals.h
@@ -28,14 +28,19 @@ class MediaInternals : public content::MediaObserver {
static MediaInternals* GetInstance();
// Overridden from content::MediaObserver:
- virtual void OnDeleteAudioStream(void* host, int stream_id) OVERRIDE;
- virtual void OnSetAudioStreamPlaying(void* host,
+ virtual void OnDeleteAudioStream(int render_process_id,
+ int render_view_id,
+ int stream_id) OVERRIDE;
+ virtual void OnSetAudioStreamPlaying(int render_process_id,
+ int render_view_id,
int stream_id,
bool playing) OVERRIDE;
- virtual void OnSetAudioStreamStatus(void* host,
+ virtual void OnSetAudioStreamStatus(int render_process_id,
+ int render_view_id,
int stream_id,
const std::string& status) OVERRIDE;
- virtual void OnSetAudioStreamVolume(void* host,
+ virtual void OnSetAudioStreamVolume(int render_process_id,
+ int render_view_id,
int stream_id,
double volume) OVERRIDE;
virtual void OnMediaEvent(int render_process_id,
@@ -63,9 +68,10 @@ class MediaInternals : public content::MediaObserver {
MediaInternals();
// Sets |property| of an audio stream to |value| and notifies observers.
- // (host, stream_id) is a unique id for the audio stream.
- // |host| will never be dereferenced.
- void UpdateAudioStream(void* host, int stream_id,
+ // (render_process_id, render_view_id, stream_id) is a unique id for the
+ // audio stream.
+ void UpdateAudioStream(int render_process_id, int render_view_id,
+ int stream_id,
const std::string& property, Value* value);
// Removes |item| from |data_|.
@@ -73,8 +79,10 @@ class MediaInternals : public content::MediaObserver {
// Sets data_.id.property = value and notifies attached UIs using update_fn.
// id may be any depth, e.g. "video.decoders.1.2.3"
- void UpdateItem(const std::string& update_fn, const std::string& id,
- const std::string& property, Value* value);
+ void UpdateItem(const std::string& update_fn,
+ int render_process_id, int render_view_id,
+ const std::string& id, const std::string& property,
+ Value* value);
// Calls javascript |function|(|value|) on each attached UI.
void SendUpdate(const std::string& function, Value* value);
« no previous file with comments | « no previous file | chrome/browser/media/media_internals.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698