Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1082163002: Scrollable should use scrollTo() when starting an animation (Closed)

Created:
5 years, 8 months ago by hansmuller
Modified:
5 years, 8 months ago
Reviewers:
hansmuller1, Hixie
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Scrollable should use scrollTo() instead of setting _scrollOffset directly, when starting an animation. I'd missed this case when adding Scrollable.scrollTo() https://codereview.chromium.org/1074033002 R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/1eb155ed8c7da36014a609cdd34b5b78d8822cee

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M sky/framework/components/scrollable.dart View 1 chunk +1 line, -5 lines 1 comment Download

Messages

Total messages: 5 (2 generated)
hansmuller1
PTAL
5 years, 8 months ago (2015-04-13 23:57:31 UTC) #3
Hixie
LGTM with the minor style change https://codereview.chromium.org/1082163002/diff/1/sky/framework/components/scrollable.dart File sky/framework/components/scrollable.dart (right): https://codereview.chromium.org/1082163002/diff/1/sky/framework/components/scrollable.dart#newcode72 sky/framework/components/scrollable.dart:72: _simulation.onTick.listen((_) {scrollTo(particle.position);}); Keep ...
5 years, 8 months ago (2015-04-14 16:52:30 UTC) #4
hansmuller
5 years, 8 months ago (2015-04-14 17:01:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1eb155ed8c7da36014a609cdd34b5b78d8822cee (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698