Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1074033002: Added Scrollable.scrollTo() (Closed)

Created:
5 years, 8 months ago by hansmuller
Modified:
5 years, 8 months ago
Reviewers:
Hixie, eseidel
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Added Scrollable.scrollTo() A subclass could override this method to limit scrolling or to initialize the scroll offset. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/5ac5f161b69f87dab6c1c3f312f589f600b21d8d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M sky/framework/components/scrollable.dart View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
hansmuller1
A small (experimental) change. PTAL
5 years, 8 months ago (2015-04-09 23:31:08 UTC) #3
eseidel
5 years, 8 months ago (2015-04-09 23:32:59 UTC) #6
Hixie
lgtm
5 years, 8 months ago (2015-04-09 23:51:27 UTC) #7
hansmuller
5 years, 8 months ago (2015-04-10 00:02:56 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5ac5f161b69f87dab6c1c3f312f589f600b21d8d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698