[DevTools] Remove dock side knowledge from browser.

chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc

Index: chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc
diff --git a/chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc b/chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc
index 8272939424f7f686737136367c50938c17f2927d..b2536c39c004c1665eab79fd2f05ffbb4ec5c85e 100644
--- a/chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc
+++ b/chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc
@@ -343,8 +343,11 @@ IN_PROC_BROWSER_TEST_F(ChromeRenderProcessHostTest,
   EXPECT_EQ(tab_count, browser()->tab_strip_model()->count());
   EXPECT_EQ(host_count, RenderProcessHostCount());
 
-  // DevTools start in docked mode (no new tab), in a separate process.
-  chrome::ToggleDevToolsWindow(browser(), DevToolsToggleAction::Inspect());
+  // Start DevTools in docked mode (no new tab).
+  // It should be in a separate process.
+  DevToolsWindow* docked_devtools = DevToolsWindow::ToggleDevToolsWindow(
+      browser(), DevToolsToggleAction::Inspect());
+  docked_devtools->SetIsDockedAndShowImmediatelyForTest(true);
   host_count++;
   EXPECT_EQ(tab_count, browser()->tab_strip_model()->count());
   EXPECT_EQ(host_count, RenderProcessHostCount());
@@ -353,8 +356,9 @@ IN_PROC_BROWSER_TEST_F(ChromeRenderProcessHostTest,
   DCHECK(devtools);
 
   // DevTools start in a separate process.
-  DevToolsWindow::ToggleDevToolsWindow(
-      devtools, true, DevToolsToggleAction::Inspect());
+  DevToolsWindow* devtools_on_self = DevToolsWindow::OpenDevToolsWindow(
+      devtools, DevToolsToggleAction::Inspect());
+  devtools_on_self->SetIsDockedAndShowImmediatelyForTest(false);
   host_count++;
   EXPECT_EQ(tab_count, browser()->tab_strip_model()->count());
   EXPECT_EQ(host_count, RenderProcessHostCount());
@@ -391,8 +395,11 @@ IN_PROC_BROWSER_TEST_F(ChromeRenderProcessHostTest,
   EXPECT_EQ(tab_count, browser()->tab_strip_model()->count());
   EXPECT_EQ(host_count, RenderProcessHostCount());
 
-  // DevTools start in docked mode (no new tab), in a separate process.
-  chrome::ToggleDevToolsWindow(browser(), DevToolsToggleAction::Inspect());
+  // Start DevTools in docked mode (no new tab).
+  // It should be in a separate process.
+  DevToolsWindow* docked_devtools = DevToolsWindow::ToggleDevToolsWindow(
+      browser(), DevToolsToggleAction::Inspect());
+  docked_devtools->SetIsDockedAndShowImmediatelyForTest(true);
   host_count++;
   EXPECT_EQ(tab_count, browser()->tab_strip_model()->count());
   EXPECT_EQ(host_count, RenderProcessHostCount());
@@ -401,8 +408,9 @@ IN_PROC_BROWSER_TEST_F(ChromeRenderProcessHostTest,
   DCHECK(devtools);
 
   // DevTools start in a separate process.
-  DevToolsWindow::ToggleDevToolsWindow(
-      devtools, true, DevToolsToggleAction::Inspect());
+  DevToolsWindow* devtools_on_self = DevToolsWindow::OpenDevToolsWindow(
+      devtools, DevToolsToggleAction::Inspect());
+  devtools_on_self->SetIsDockedAndShowImmediatelyForTest(false);
   host_count++;
   EXPECT_EQ(tab_count, browser()->tab_strip_model()->count());
   EXPECT_EQ(host_count, RenderProcessHostCount());