[DevTools] Remove dock side knowledge from browser.

chrome/browser/ui/cocoa/view_id_util_browsertest.mm

Index: chrome/browser/ui/cocoa/view_id_util_browsertest.mm
diff --git a/chrome/browser/ui/cocoa/view_id_util_browsertest.mm b/chrome/browser/ui/cocoa/view_id_util_browsertest.mm
index 95d3a6a85ee3f787d3e03684fdd305b27862b861..b327ba0211f832cfdc769f974775c1b0dc74ebe8 100644
--- a/chrome/browser/ui/cocoa/view_id_util_browsertest.mm
+++ b/chrome/browser/ui/cocoa/view_id_util_browsertest.mm
@@ -10,6 +10,7 @@
 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
 #include "chrome/browser/bookmarks/bookmark_test_helpers.h"
 #include "chrome/browser/bookmarks/bookmark_utils.h"
+#include "chrome/browser/devtools/devtools_window.h"
 #include "chrome/browser/download/download_shelf.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
@@ -47,9 +48,9 @@ class ViewIDTest : public InProcessBrowserTest {
     chrome::ShowFindBar(browser());
 
     // Make sure docked devtools is created to test VIEW_ID_DEV_TOOLS_DOCKED
-    browser()->profile()->GetPrefs()->SetString(prefs::kDevToolsDockSide,
-                                                "dock_bottom");
-    chrome::ToggleDevToolsWindow(browser(), DevToolsToggleAction::Inspect());
+    DevToolsWindow* devtools = DevToolsWindow::ToggleDevToolsWindow(
+        browser(), DevToolsToggleAction::Inspect());
+    devtools->SetIsDockedAndShowImmediatelyForTest(true);

[pfeldman, 2014/01/09 12:52:01]

Could you inline the one above into this method to minimize the call-sites
impact?

[dgozman, 2014/01/14 15:26:17]

Done.

 
     // Make sure download shelf is created to test VIEW_ID_DOWNLOAD_SHELF
     browser()->window()->GetDownloadShelf()->Show();