[DevTools] Remove dock side knowledge from browser.

chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/devtools/devtools_window.h"
 #include "chrome/browser/search/search.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_commands.h"
@@ skipping 325 matching lines @@
   GURL page1("data:text/html,hello world1");
   ui_test_utils::WindowedTabAddedNotificationObserver observer1(
       content::NotificationService::AllSources());
   chrome::ShowSingletonTab(browser(), page1);
   observer1.Wait();
   tab_count++;
   host_count++;
   EXPECT_EQ(tab_count, browser()->tab_strip_model()->count());
   EXPECT_EQ(host_count, RenderProcessHostCount());
 
-  // DevTools start in docked mode (no new tab), in a separate process.
-  chrome::ToggleDevToolsWindow(browser(), DevToolsToggleAction::Inspect());
+  // Start DevTools in docked mode (no new tab).
+  // It should be in a separate process.
+  DevToolsWindow* docked_devtools = DevToolsWindow::ToggleDevToolsWindow(
+      browser(), DevToolsToggleAction::Inspect());
+  docked_devtools->SetIsDockedAndShowImmediatelyForTest(true);
   host_count++;
   EXPECT_EQ(tab_count, browser()->tab_strip_model()->count());
   EXPECT_EQ(host_count, RenderProcessHostCount());
 
   RenderViewHost* devtools = FindFirstDevToolsHost();
   DCHECK(devtools);
 
   // DevTools start in a separate process.
-  DevToolsWindow::ToggleDevToolsWindow(
-      devtools, true, DevToolsToggleAction::Inspect());
+  DevToolsWindow* devtools_on_self = DevToolsWindow::OpenDevToolsWindow(
+      devtools, DevToolsToggleAction::Inspect());
+  devtools_on_self->SetIsDockedAndShowImmediatelyForTest(false);
   host_count++;
   EXPECT_EQ(tab_count, browser()->tab_strip_model()->count());
   EXPECT_EQ(host_count, RenderProcessHostCount());
 
   // close docked devtools
   content::WindowedNotificationObserver close_observer(
       content::NOTIFICATION_WEB_CONTENTS_DESTROYED,
       content::Source<WebContents>(WebContents::FromRenderViewHost(devtools)));
 
   chrome::ToggleDevToolsWindow(browser(), DevToolsToggleAction::Toggle());
@@ skipping 16 matching lines @@
   GURL page1("data:text/html,hello world1");
   ui_test_utils::WindowedTabAddedNotificationObserver observer1(
       content::NotificationService::AllSources());
   chrome::ShowSingletonTab(browser(), page1);
   observer1.Wait();
   tab_count++;
   host_count++;
   EXPECT_EQ(tab_count, browser()->tab_strip_model()->count());
   EXPECT_EQ(host_count, RenderProcessHostCount());
 
-  // DevTools start in docked mode (no new tab), in a separate process.
-  chrome::ToggleDevToolsWindow(browser(), DevToolsToggleAction::Inspect());
+  // Start DevTools in docked mode (no new tab).
+  // It should be in a separate process.
+  DevToolsWindow* docked_devtools = DevToolsWindow::ToggleDevToolsWindow(
+      browser(), DevToolsToggleAction::Inspect());
+  docked_devtools->SetIsDockedAndShowImmediatelyForTest(true);
   host_count++;
   EXPECT_EQ(tab_count, browser()->tab_strip_model()->count());
   EXPECT_EQ(host_count, RenderProcessHostCount());
 
   RenderViewHost* devtools = FindFirstDevToolsHost();
   DCHECK(devtools);
 
   // DevTools start in a separate process.
-  DevToolsWindow::ToggleDevToolsWindow(
-      devtools, true, DevToolsToggleAction::Inspect());
+  DevToolsWindow* devtools_on_self = DevToolsWindow::OpenDevToolsWindow(
+      devtools, DevToolsToggleAction::Inspect());
+  devtools_on_self->SetIsDockedAndShowImmediatelyForTest(false);
   host_count++;
   EXPECT_EQ(tab_count, browser()->tab_strip_model()->count());
   EXPECT_EQ(host_count, RenderProcessHostCount());
 
   // close docked devtools
   content::WindowedNotificationObserver close_observer(
       content::NOTIFICATION_WEB_CONTENTS_DESTROYED,
       content::Source<content::WebContents>(
           WebContents::FromRenderViewHost(devtools)));
   chrome::ToggleDevToolsWindow(browser(), DevToolsToggleAction::Toggle());
@@ skipping 55 matching lines @@
       chrome::NOTIFICATION_BROWSER_CLOSED,
       content::NotificationService::AllSources());
 
   // Kill the renderer process, simulating a crash. This should the ProcessDied
   // method to be called. Alternatively, RenderProcessHost::OnChannelError can
   // be called to directly force a call to ProcessDied.
   base::KillProcess(wc1->GetRenderProcessHost()->GetHandle(), -1, true);
 
   observer.Wait();
 }