Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1453)

Unified Diff: chrome/browser/policy/policy_browsertest.cc

Issue 108213012: [DevTools] Remove dock side knowledge from browser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More test magic Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/policy/policy_browsertest.cc
diff --git a/chrome/browser/policy/policy_browsertest.cc b/chrome/browser/policy/policy_browsertest.cc
index ac2c45cbeae1be97029e2faf89e44c5869388dcd..8b33721e03e3094444fc35760dd9f785438faec2 100644
--- a/chrome/browser/policy/policy_browsertest.cc
+++ b/chrome/browser/policy/policy_browsertest.cc
@@ -1346,7 +1346,8 @@ IN_PROC_BROWSER_TEST_F(PolicyTest, DeveloperToolsDisabled) {
content::WebContents* contents =
browser()->tab_strip_model()->GetActiveWebContents();
DevToolsWindow *devtools_window =
- DevToolsWindow::GetDockedInstanceForInspectedTab(contents);
+ DevToolsWindow::GetInstanceForInspectedRenderViewHost(
+ contents->GetRenderViewHost());
EXPECT_TRUE(devtools_window);
// Disable devtools via policy.
@@ -1360,10 +1361,12 @@ IN_PROC_BROWSER_TEST_F(PolicyTest, DeveloperToolsDisabled) {
// wait for devtools close
close_observer.Wait();
// The existing devtools window should have closed.
- EXPECT_FALSE(DevToolsWindow::GetDockedInstanceForInspectedTab(contents));
+ EXPECT_FALSE(DevToolsWindow::GetInstanceForInspectedRenderViewHost(
+ contents->GetRenderViewHost()));
// And it's not possible to open it again.
EXPECT_FALSE(chrome::ExecuteCommand(browser(), IDC_DEV_TOOLS));
- EXPECT_FALSE(DevToolsWindow::GetDockedInstanceForInspectedTab(contents));
+ EXPECT_FALSE(DevToolsWindow::GetInstanceForInspectedRenderViewHost(
+ contents->GetRenderViewHost()));
}
// TODO(samarth): remove along with rest of NTP4 code.

Powered by Google App Engine
This is Rietveld 408576698