Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 1081113002: Revert of [Extensions] Make extension message bubble factory platform-abstract (Closed)

Created:
5 years, 8 months ago by Devlin
Modified:
5 years, 8 months ago
Reviewers:
Finnur, Nico, sky
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Extensions] Make extension message bubble factory platform-abstract (patchset #4 id:120001 of https://codereview.chromium.org/1078543002/) Reason for revert: Looks like this caused crbug.com/476426. Reverting to investigate. Original issue's description: > [Extensions] Make extension message bubble factory platform-abstract > > We want to show extension message bubbles on multiple platforms; > the first step towards this is to make the bubble factory > platform-abstract. Do so, and as an added bonus, shave off > 200 lines of code. > > BUG=474092 > > Committed: https://crrev.com/a9a17da0de2260f6cb1a10b542a6d3a2b5fbf504 > Cr-Commit-Position: refs/heads/master@{#324715} TBR=finnur@chromium.org,sky@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=474092 Committed: https://crrev.com/86261efe450def1b2c9b55514d40fb5c14290817 Cr-Commit-Position: refs/heads/master@{#324876}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+527 lines, -343 lines) Patch
M chrome/browser/extensions/dev_mode_bubble_controller.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_message_bubble.h View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_message_bubble_controller.h View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/extensions/extension_message_bubble_controller.cc View 2 chunks +14 lines, -9 lines 0 comments Download
M chrome/browser/extensions/extension_message_bubble_controller_unittest.cc View 20 chunks +48 lines, -48 lines 0 comments Download
M chrome/browser/extensions/ntp_overridden_bubble_controller.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/extensions/proxy_overridden_bubble_controller.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/extensions/settings_api_bubble_controller.h View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/extensions/settings_api_bubble_controller.cc View 3 chunks +3 lines, -24 lines 0 comments Download
M chrome/browser/extensions/suspicious_extension_bubble_controller.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/ui/extensions/OWNERS View 1 chunk +1 line, -4 lines 0 comments Download
D chrome/browser/ui/extensions/extension_message_bubble_factory.h View 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/browser/ui/extensions/extension_message_bubble_factory.cc View 1 chunk +0 lines, -92 lines 0 comments Download
M chrome/browser/ui/toolbar/toolbar_actions_bar.h View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/toolbar/toolbar_actions_bar.cc View 4 chunks +1 line, -19 lines 0 comments Download
M chrome/browser/ui/toolbar/toolbar_actions_bar_delegate.h View 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_message_bubble_view.h View 4 chunks +125 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_message_bubble_view.cc View 7 chunks +275 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/settings_api_bubble_helper_views.cc View 3 chunks +25 lines, -15 lines 0 comments Download
M chrome/browser/ui/views/toolbar/browser_actions_container.h View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/toolbar/browser_actions_container.cc View 4 chunks +0 lines, -29 lines 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_view.h View 3 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_view.cc View 3 chunks +13 lines, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Devlin
Created Revert of [Extensions] Make extension message bubble factory platform-abstract
5 years, 8 months ago (2015-04-13 17:40:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1081113002/1
5 years, 8 months ago (2015-04-13 17:40:56 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-13 17:42:40 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/86261efe450def1b2c9b55514d40fb5c14290817 Cr-Commit-Position: refs/heads/master@{#324876}
5 years, 8 months ago (2015-04-13 17:43:28 UTC) #4
Nico
5 years, 8 months ago (2015-04-13 20:46:57 UTC) #6
Message was sent while issue was closed.
Thanks for the revert! This helped:
http://build.chromium.org/p/chromium.fyi/builders/CrWinClang%20tester/builds/321

I haven't yet tried to build browser_tests with msvs in official mode. Let me
know if you can't repro this in an official build with msvs, then I'll check if
this is compiler-specific for some reason.

Powered by Google App Engine
This is Rietveld 408576698