Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: chrome/browser/extensions/settings_api_bubble_controller.h

Issue 1081113002: Revert of [Extensions] Make extension message bubble factory platform-abstract (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_SETTINGS_API_BUBBLE_CONTROLLER_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_SETTINGS_API_BUBBLE_CONTROLLER_H_
6 #define CHROME_BROWSER_EXTENSIONS_SETTINGS_API_BUBBLE_CONTROLLER_H_ 6 #define CHROME_BROWSER_EXTENSIONS_SETTINGS_API_BUBBLE_CONTROLLER_H_
7 7
8 #include <string> 8 #include <string>
9
10 #include "chrome/browser/extensions/extension_message_bubble_controller.h" 9 #include "chrome/browser/extensions/extension_message_bubble_controller.h"
11 #include "chrome/common/extensions/manifest_handlers/settings_overrides_handler. h" 10 #include "chrome/common/extensions/manifest_handlers/settings_overrides_handler. h"
12 11
13 namespace extensions { 12 namespace extensions {
14 13
15 class SettingsApiBubble; 14 class SettingsApiBubble;
16 15
17 class SettingsApiBubbleController : public ExtensionMessageBubbleController { 16 class SettingsApiBubbleController : public ExtensionMessageBubbleController {
18 public: 17 public:
19 SettingsApiBubbleController(Profile* profile, SettingsApiOverrideType type); 18 SettingsApiBubbleController(Profile* profile, SettingsApiOverrideType type);
20 ~SettingsApiBubbleController() override; 19 ~SettingsApiBubbleController() override;
21 20
22 // Returns true if we should show the bubble for the extension actively 21 // Whether the controller knows that we should show the bubble for extension
23 // overriding the setting of |type_|. 22 // with |extension_id|. Returns true if so.
24 bool ShouldShow(); 23 bool ShouldShow(const std::string& extension_id);
25 24
26 // ExtensionMessageBubbleController: 25 // ExtensionMessageBubbleController:
27 bool CloseOnDeactivate() override; 26 bool CloseOnDeactivate() override;
28 27
29 private: 28 private:
30 // A weak pointer to the profile we are associated with. Not owned by us. 29 // A weak pointer to the profile we are associated with. Not owned by us.
31 Profile* profile_; 30 Profile* profile_;
32 31
33 // The type of settings override this bubble will report on. 32 // The type of settings override this bubble will report on.
34 SettingsApiOverrideType type_; 33 SettingsApiOverrideType type_;
35 34
36 DISALLOW_COPY_AND_ASSIGN(SettingsApiBubbleController); 35 DISALLOW_COPY_AND_ASSIGN(SettingsApiBubbleController);
37 }; 36 };
38 37
39 } // namespace extensions 38 } // namespace extensions
40 39
41 #endif // CHROME_BROWSER_EXTENSIONS_SETTINGS_API_BUBBLE_CONTROLLER_H_ 40 #endif // CHROME_BROWSER_EXTENSIONS_SETTINGS_API_BUBBLE_CONTROLLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698