chrome/browser/ui/toolbar/toolbar_actions_bar.h - Issue 1081113002: Revert of [Extensions] Make extension message bubble factory platform-abstract

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/toolbar/toolbar_actions_bar.h

Issue 1081113002: Revert of [Extensions] Make extension message bubble factory platform-abstract (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/extensions/extension_message_bubble_factory.cc ('k') | chrome/browser/ui/toolbar/toolbar_actions_bar.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/toolbar/toolbar_actions_bar.h

diff --git a/chrome/browser/ui/toolbar/toolbar_actions_bar.h b/chrome/browser/ui/toolbar/toolbar_actions_bar.h

index 11a89021c6177069036fb5db66ab4d833ed6b5f3..3a6798fc29a10a08f7d57583cb485b201263c7ec 100644

--- a/chrome/browser/ui/toolbar/toolbar_actions_bar.h

+++ b/chrome/browser/ui/toolbar/toolbar_actions_bar.h

@@ -198,9 +198,6 @@

// Sets |overflowed_action_wants_to_run_| to the proper value.

void SetOverflowedActionWantsToRun();

- // Shows an extension message bubble, if any should be shown.

- void MaybeShowExtensionBubble();

bool in_overflow_mode() const { return main_bar_ != nullptr; }

// The delegate for this object (in a real build, this is the view).

@@ -250,10 +247,6 @@

// True if an action in the overflow menu wants to run.

bool overflowed_action_wants_to_run_;

- // True if we have checked to see if there is an extension bubble that should

- // be displayed, and, if there is, shown that bubble.

- bool checked_extension_bubble_;

DISALLOW_COPY_AND_ASSIGN(ToolbarActionsBar);

};